Remove remaining code related to pageLauncher

Remove remaining code related to pageLauncher.

BUG=264624
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214625

[zhchbin, 2013-07-29 13:27:46]

Please review.

[not at google - send to devlin, 2013-07-29 14:54:00]

I don't understand the test.

[zhchbin, 2013-07-29 15:04:44]

On 2013/07/29 14:54:00, kalman wrote:
> I don't understand the test.

Please refer to http://code.google.com/p/chromium/issues/detail?id=256981#c12.
And these issue is caused by the remaining code in the _api_features.json of an
incomplete API removals. You can run the test case without patch of
_api_features.json, it should crash and fail.

[not at google - send to devlin, 2013-07-29 15:13:03]

seems like we're testing an implementation detail of chrome. We already have
ExtensionApITest.Stubs which does a similar thing, I'd prefer it if we improved
that test instead.

[zhchbin, 2013-07-29 15:16:54]

On 2013/07/29 15:13:03, kalman wrote:
> seems like we're testing an implementation detail of chrome. We already have
> ExtensionApITest.Stubs which does a similar thing, I'd prefer it if we
improved
> that test instead.

Got it, I will update the test case tomorrow (night on my side.). Thanks for
your instruction.

[zhchbin, 2013-07-30 03:47:08]

On 2013/07/29 15:13:03, kalman wrote:
> seems like we're testing an implementation detail of chrome. We already have
> ExtensionApITest.Stubs which does a similar thing, I'd prefer it if we
improved
> that test instead.

Done, please take a look.

[not at google - send to devlin, 2013-07-30 19:45:13]

Ok this test still makes me uneasy. Testing the sideeffect of a bug, where the
sideeffect might not always exist. So it's unlikely to always be useful.

I'd rather we add a presubmit that every API in _api_features.json has a
corresponding schema file, and that every schema file has an entry in
_api_features.json.

(except for devtools, which is a special case).

[zhchbin, 2013-07-31 01:09:58]

On 2013/07/30 19:45:13, kalman wrote:
> Ok this test still makes me uneasy. Testing the sideeffect of a bug, where the
> sideeffect might not always exist. So it's unlikely to always be useful.
> 
> I'd rather we add a presubmit that every API in _api_features.json has a
> corresponding schema file, and that every schema file has an entry in
> _api_features.json.
> 
> (except for devtools, which is a special case).

Sorry for I didn't know python and presubmit well, so I remove the test case
though AFAICS it's no a big problem. The case is simple which I think it can
take only a little time to run it.

[not at google - send to devlin, 2013-07-31 01:35:49]

lgtm, we can figure out the presubmit sometime later.

[commit-bot: I haz the power, 2013-07-31 02:02:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zhchbin@gmail.com/21028005/12001

[commit-bot: I haz the power, 2013-07-31 07:59:23]

Change committed as 214625