arc: Implement silent OptIn mode for managed Arc.

arc: Implement silent OptIn mode for managed Arc.

BUG=b/28987931
BUG=b/29121207
TEST=Manually on device. In case Arc is managed no UI is shown and
     Arc is started automatically. Emulate error and OptIn is
     automatically recovered without user interaction.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/146d8abde33c689871bd75b5057a753229657659
Cr-Commit-Position: refs/heads/master@{#402635}

[khmel, 2016-06-27 21:14:14]

Description was changed from

==========
arc: Implement silent OptIn mode for managed Arc.

BUG=b/28987931
BUG=b/29121207
TEST=Manually on device. In case Arc is managed no UI is shown and
     Arc is started automatically. Emulate error and OptIn is
     automatically recovered without user interaction.
==========

to

==========
arc: Implement silent OptIn mode for managed Arc.

BUG=b/28987931
BUG=b/29121207
TEST=Manually on device. In case Arc is managed no UI is shown and
     Arc is started automatically. Emulate error and OptIn is
     automatically recovered without user interaction.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[khmel, 2016-06-27 22:31:48]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2016-06-27 22:31:49]

Hi Xiyuan,

There is no GAIA api currently to request auth code silently. As discussed in
b/29121207 workaround is to press 'sign in' button programatically.
Current solution for managed Arc
1. Don't show OptIn window to user.
2. Start directly from LSO page.
3. In case initial LSO is loaded - try to submit form automatically via
javascript.
4. Register timeout for each page except 'arc-loading'. Timeout automatically
restart requesting auth code.

PTAL

[xiyuan, 2016-06-27 23:20:42]

lgtm

Feels really hacky, but...

https://codereview.chromium.org/2102793002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/arc_support/background.js (right):

https://codereview.chromium.org/2102793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/background.js:101: function
initialize(data, deviceId, _silentMode) {
This looks strange. To avoid the name conflict, we can do

window.silentMode = sildentMode;

in line 103, instead of prefxing with "_".

https://codereview.chromium.org/2102793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/background.js:350: var
submitAproveCode =
submitAproveCode -> submitAp*p*roveCode

[khmel, 2016-06-28 20:05:39]

Thanks Xiyuan for your review.

I did more testing and found 2 issues:
1. I missed that prepare context is required for LSO. Before it was called after
'Agree' button press. Now it is called immediately for managed Arc. 
2. It was hidden before with manual OptIn flow. Now, with automatic sign in it
comes to surface. If refresh token is not set merge fetcher fails. So solution
is similar to our previous CL, wait for refresh token if required.
3. IMHO ArcAuthService has inclination to be overcomplicated. We extracted
AndroidManagement check in previous CL. Now I extract low level context
preparation to separate class and leaving high level code only in
ArcAuthService. I think this improves readability.
WDYT?

PTAL

https://codereview.chromium.org/2102793002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/arc_support/background.js (right):

https://codereview.chromium.org/2102793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/background.js:101: function
initialize(data, deviceId, _silentMode) {
On 2016/06/27 23:20:42, xiyuan wrote:
> This looks strange. To avoid the name conflict, we can do
> 
> window.silentMode = sildentMode;
> 
> in line 103, instead of prefxing with "_".

Thanks, that it is what I was looking for.

https://codereview.chromium.org/2102793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/background.js:350: var
submitAproveCode =
On 2016/06/27 23:20:42, xiyuan wrote:
> submitAproveCode -> submitAp*p*roveCode

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_android_management_checker.cc (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_android_management_checker.cc:47:
DCHECK(background_mode_);
Now this can not happen in foreground mode so discard unused code.

[xiyuan, 2016-06-28 21:49:14]

slgtm

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_context.cc (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.cc:24: }
nit: insert an empty line before, and add "// namesapce"

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_context.h (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.h:22: 
nit: namespace arc { ?

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.h:34: ProfileOAuth2TokenService*
token_service() { return token_service_; }
nit: move the two accessor to the end of declartions, i.e. after all other
public methods

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.h:60: content::StoragePartition*
storage_partition_;
nit: = nullptr ?

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_context_delegate.h (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context_delegate.h:7: 
namespace arc { ?

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_service.cc:638: void
ArcAuthService::CheckAndroidManagement(bool backround_mode) {
nit: fix spelling, backround_mode -> back*g*round_mode

[khmel, 2016-06-29 00:33:40]

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_context.cc (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.cc:24: }
On 2016/06/28 21:49:13, xiyuan wrote:
> nit: insert an empty line before, and add "// namesapce"

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_context.h (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.h:22: 
On 2016/06/28 21:49:13, xiyuan wrote:
> nit: namespace arc { ?

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.h:34: ProfileOAuth2TokenService*
token_service() { return token_service_; }
On 2016/06/28 21:49:13, xiyuan wrote:
> nit: move the two accessor to the end of declartions, i.e. after all other
> public methods

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.h:60: content::StoragePartition*
storage_partition_;
On 2016/06/28 21:49:13, xiyuan wrote:
> nit: = nullptr ?

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_context_delegate.h (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context_delegate.h:7: 
On 2016/06/28 21:49:13, xiyuan wrote:
> namespace arc { ?

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_service.cc:638: void
ArcAuthService::CheckAndroidManagement(bool backround_mode) {
On 2016/06/28 21:49:13, xiyuan wrote:
> nit: fix spelling, backround_mode -> back*g*round_mode

Done.

[khmel, 2016-06-29 00:33:40]

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_context.cc (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.cc:24: }
On 2016/06/28 21:49:13, xiyuan wrote:
> nit: insert an empty line before, and add "// namesapce"

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_context.h (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.h:22: 
On 2016/06/28 21:49:13, xiyuan wrote:
> nit: namespace arc { ?

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.h:34: ProfileOAuth2TokenService*
token_service() { return token_service_; }
On 2016/06/28 21:49:13, xiyuan wrote:
> nit: move the two accessor to the end of declartions, i.e. after all other
> public methods

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context.h:60: content::StoragePartition*
storage_partition_;
On 2016/06/28 21:49:13, xiyuan wrote:
> nit: = nullptr ?

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_context_delegate.h (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_context_delegate.h:7: 
On 2016/06/28 21:49:13, xiyuan wrote:
> namespace arc { ?

Done.

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2102793002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_service.cc:638: void
ArcAuthService::CheckAndroidManagement(bool backround_mode) {
On 2016/06/28 21:49:13, xiyuan wrote:
> nit: fix spelling, backround_mode -> back*g*round_mode

Done.

[khmel, 2016-06-29 00:33:51]

The CQ bit was checked by khmel@chromium.org

[khmel, 2016-06-29 00:33:51]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2102793002/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2016-06-29 00:36:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:47:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-29 01:50:11]

Description was changed from

==========
arc: Implement silent OptIn mode for managed Arc.

BUG=b/28987931
BUG=b/29121207
TEST=Manually on device. In case Arc is managed no UI is shown and
     Arc is started automatically. Emulate error and OptIn is
     automatically recovered without user interaction.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
arc: Implement silent OptIn mode for managed Arc.

BUG=b/28987931
BUG=b/29121207
TEST=Manually on device. In case Arc is managed no UI is shown and
     Arc is started automatically. Emulate error and OptIn is
     automatically recovered without user interaction.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/146d8abde33c689871bd75b5057a753229657659
Cr-Commit-Position: refs/heads/master@{#402635}
==========

[commit-bot: I haz the power, 2016-06-29 01:50:13]

Patchset 4 (id:??) landed as
https://crrev.com/146d8abde33c689871bd75b5057a753229657659
Cr-Commit-Position: refs/heads/master@{#402635}

[victorhsieh0, 2016-06-29 20:01:51]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2108643007/ by victorhsieh@google.com.

The reason for reverting is: This change allows automatic auth code generation
and is considered as risky in production..