components/certificate_transparency/pref_names.h - Issue 2102783003: Add enterprise policy to exempt hosts from Certificate Transparency

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/certificate_transparency/pref_names.h

Issue 2102783003: Add enterprise policy to exempt hosts from Certificate Transparency (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enterprise_ct

Patch Set: Combine with https://codereview.chromium.org/2087743002 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/certificate_transparency/ct_policy_manager_unittest.cc ('K') | « components/certificate_transparency/ct_policy_manager_unittest.cc ('k') | components/certificate_transparency/pref_names.cc » ('j') | net/http/transport_security_state.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_CERTIFICATE_TRANSPARENCY_PREF_NAMES_H_

	6 #define COMPONENTS_CERTIFICATE_TRANSPARENCY_PREF_NAMES_H_

	7

	8 namespace certificate_transparency {

	9 namespace prefs {

	10

	11 // The set of hosts (as URLBlacklist-syntax filters) for which Certificate

	12 // Transparency is required to be present.

	13 extern const char kCTRequiredHosts[];
	battre 2016/06/28 08:33:13 Why do you add this if it is not controllable by p Why do you add this if it is not controllable by policy? Ryan Sleevi 2016/06/28 16:41:27 Honestly? Mostly for testing purposes (it was easi Show quoted text On 2016/06/28 08:33:13, battre wrote: > Why do you add this if it is not controllable by policy? Honestly? Mostly for testing purposes (it was easier to test with this). I'd like to expose it via policy, but I was happy to wait for M-54 to actually add that bit. battre 2016/06/29 09:14:43 Acknowledged. Show quoted text On 2016/06/28 16:41:27, Ryan Sleevi wrote: > On 2016/06/28 08:33:13, battre wrote: > > Why do you add this if it is not controllable by policy? > > Honestly? Mostly for testing purposes (it was easier to test with this). I'd > like to expose it via policy, but I was happy to wait for M-54 to actually add > that bit. Acknowledged.
	14

	15 // The set of hosts (as URLBlacklist-syntax filters) for which Certificate

	16 // Transparency information is allowed to be absent, even if it would

	17 // otherwise be required (e.g. as part of security policy).

	18 extern const char kCTExcludedHosts[];
	battre 2016/06/28 08:33:13 Do you want to add a comment which one wins in cas Do you want to add a comment which one wins in case both match? Ryan Sleevi 2016/06/28 16:41:27 Should that be with the Pref? I felt like the pref Show quoted text On 2016/06/28 08:33:13, battre wrote: > Do you want to add a comment which one wins in case both match? Should that be with the Pref? I felt like the pref itself doesn't make any commitment, it's the thing that glues multiple prefs together (the CTPolicyManager) battre 2016/06/29 09:14:43 Hm. It's just the place I would look for this info Show quoted text On 2016/06/28 16:41:27, Ryan Sleevi wrote: > On 2016/06/28 08:33:13, battre wrote: > > Do you want to add a comment which one wins in case both match? > > Should that be with the Pref? I felt like the pref itself doesn't make any > commitment, it's the thing that glues multiple prefs together (the > CTPolicyManager) Hm. It's just the place I would look for this information. Up to you.
	19

	20 } // namespace prefs

	21 } // namespace certificate_transparency

	22

	23 #endif // COMPONENTS_CERTIFICATE_TRANSPARENCY_PREF_NAMES_H_

OLD	NEW