Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2102773002: Add eg test for webScenarioBrowsingUnsupportedSchema. (Closed)

Created:
4 years, 5 months ago by huangml
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add eg test for webScenarioBrowsingUnsupportedSchema. BUG=612961 Committed: https://crrev.com/aaf2d34b0b84feaecb14e02ee495b45e2e6d993b Cr-Commit-Position: refs/heads/master@{#402608}

Patch Set 1 #

Total comments: 3

Patch Set 2 : nits #

Total comments: 1

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M ios/web/shell/test/web_shell_navigation_egtest.mm View 1 2 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
huangml1
Test about unsupported scheme. PTAL, thanks!
4 years, 5 months ago (2016-06-27 20:40:24 UTC) #2
Eugene But (OOO till 7-30)
lgtm with nits https://codereview.chromium.org/2102773002/diff/1/ios/web/shell/test/web_shell_navigation_egtest.mm File ios/web/shell/test/web_shell_navigation_egtest.mm (right): https://codereview.chromium.org/2102773002/diff/1/ios/web/shell/test/web_shell_navigation_egtest.mm#newcode174 ios/web/shell/test/web_shell_navigation_egtest.mm:174: // Tests tapping on an unsupported ...
4 years, 5 months ago (2016-06-27 21:13:28 UTC) #3
baxley
lgtm https://codereview.chromium.org/2102773002/diff/20001/ios/web/shell/test/web_shell_navigation_egtest.mm File ios/web/shell/test/web_shell_navigation_egtest.mm (right): https://codereview.chromium.org/2102773002/diff/20001/ios/web/shell/test/web_shell_navigation_egtest.mm#newcode184 ios/web/shell/test/web_shell_navigation_egtest.mm:184: "navigation!'));" super-nit: I think this should be indented ...
4 years, 5 months ago (2016-06-28 14:21:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102773002/40001
4 years, 5 months ago (2016-06-28 19:42:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/88701) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 5 months ago (2016-06-28 19:48:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102773002/40001
4 years, 5 months ago (2016-06-28 22:28:04 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 00:10:11 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 00:14:31 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aaf2d34b0b84feaecb14e02ee495b45e2e6d993b
Cr-Commit-Position: refs/heads/master@{#402608}

Powered by Google App Engine
This is Rietveld 408576698