Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2102763002: Removed unnecessary assertion (Closed)

Created:
4 years, 5 months ago by smaier
Modified:
4 years, 5 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unnecessary assertion BUG=None Committed: https://crrev.com/30edb12909579540d70fcb3713ed37c3c65f26ee Cr-Commit-Position: refs/heads/master@{#402366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/android/gyp/util/proguard_util.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
smaier
4 years, 5 months ago (2016-06-27 20:04:50 UTC) #2
agrieve
On 2016/06/27 20:04:50, smaier wrote: lgtm
4 years, 5 months ago (2016-06-27 20:37:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102763002/1
4 years, 5 months ago (2016-06-27 20:41:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/253220)
4 years, 5 months ago (2016-06-27 23:46:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102763002/1
4 years, 5 months ago (2016-06-28 00:05:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 01:41:36 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 01:43:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30edb12909579540d70fcb3713ed37c3c65f26ee
Cr-Commit-Position: refs/heads/master@{#402366}

Powered by Google App Engine
This is Rietveld 408576698