Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: net/quic/quic_connection_test.cc

Issue 2102713002: Remove two tests from QuicConnectionTest because they were duplicates of those in QuicPacketCreator… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@125572214
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index 00d17fce8d0be8c4a8acf4b924f4112e99e0cfc6..80ba471ae07c3205923f2edd6e1a5fc724c01eb9 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -1611,103 +1611,6 @@ TEST_P(QuicConnectionTest, AckAll) {
ProcessAckPacket(&frame1);
}
-TEST_P(QuicConnectionTest, SendingDifferentSequenceNumberLengthsBandwidth) {
- QuicPacketNumber last_packet;
- SendStreamDataToPeer(1, "foo", 0, !kFin, &last_packet);
- EXPECT_EQ(1u, last_packet);
- EXPECT_EQ(PACKET_1BYTE_PACKET_NUMBER,
- QuicPacketCreatorPeer::NextPacketNumberLength(creator_));
- EXPECT_EQ(PACKET_1BYTE_PACKET_NUMBER,
- writer_->header().public_header.packet_number_length);
-
- EXPECT_CALL(*send_algorithm_, GetCongestionWindow())
- .WillRepeatedly(Return(kMaxPacketSize * 256));
-
- SendStreamDataToPeer(1, "bar", 3, !kFin, &last_packet);
- EXPECT_EQ(2u, last_packet);
- EXPECT_EQ(PACKET_2BYTE_PACKET_NUMBER,
- QuicPacketCreatorPeer::NextPacketNumberLength(creator_));
- // The 1 packet lag is due to the packet number length being recalculated in
- // QuicConnection after a packet is sent.
- EXPECT_EQ(PACKET_1BYTE_PACKET_NUMBER,
- writer_->header().public_header.packet_number_length);
-
- EXPECT_CALL(*send_algorithm_, GetCongestionWindow())
- .WillRepeatedly(Return(kMaxPacketSize * 256 * 256));
-
- SendStreamDataToPeer(1, "foo", 6, !kFin, &last_packet);
- EXPECT_EQ(3u, last_packet);
- EXPECT_EQ(PACKET_4BYTE_PACKET_NUMBER,
- QuicPacketCreatorPeer::NextPacketNumberLength(creator_));
- EXPECT_EQ(PACKET_2BYTE_PACKET_NUMBER,
- writer_->header().public_header.packet_number_length);
-
- EXPECT_CALL(*send_algorithm_, GetCongestionWindow())
- .WillRepeatedly(Return(kMaxPacketSize * 256 * 256 * 256));
-
- SendStreamDataToPeer(1, "bar", 9, !kFin, &last_packet);
- EXPECT_EQ(4u, last_packet);
- EXPECT_EQ(PACKET_4BYTE_PACKET_NUMBER,
- QuicPacketCreatorPeer::NextPacketNumberLength(creator_));
- EXPECT_EQ(PACKET_4BYTE_PACKET_NUMBER,
- writer_->header().public_header.packet_number_length);
-
- EXPECT_CALL(*send_algorithm_, GetCongestionWindow())
- .WillRepeatedly(Return(kMaxPacketSize * 256 * 256 * 256 * 256));
-
- SendStreamDataToPeer(1, "foo", 12, !kFin, &last_packet);
- EXPECT_EQ(5u, last_packet);
- EXPECT_EQ(PACKET_6BYTE_PACKET_NUMBER,
- QuicPacketCreatorPeer::NextPacketNumberLength(creator_));
- EXPECT_EQ(PACKET_4BYTE_PACKET_NUMBER,
- writer_->header().public_header.packet_number_length);
-}
-
-// TODO(ianswett): Re-enable this test by finding a good way to test different
-// packet number lengths without sending packets with giant gaps.
-TEST_P(QuicConnectionTest,
- DISABLED_SendingDifferentSequenceNumberLengthsUnackedDelta) {
- QuicPacketNumber last_packet;
- SendStreamDataToPeer(1, "foo", 0, !kFin, &last_packet);
- EXPECT_EQ(1u, last_packet);
- EXPECT_EQ(PACKET_1BYTE_PACKET_NUMBER,
- QuicPacketCreatorPeer::NextPacketNumberLength(creator_));
- EXPECT_EQ(PACKET_1BYTE_PACKET_NUMBER,
- writer_->header().public_header.packet_number_length);
-
- QuicPacketCreatorPeer::SetPacketNumber(&peer_creator_, 100);
-
- SendStreamDataToPeer(1, "bar", 3, !kFin, &last_packet);
- EXPECT_EQ(PACKET_2BYTE_PACKET_NUMBER,
- QuicPacketCreatorPeer::NextPacketNumberLength(creator_));
- EXPECT_EQ(PACKET_1BYTE_PACKET_NUMBER,
- writer_->header().public_header.packet_number_length);
-
- QuicPacketCreatorPeer::SetPacketNumber(&peer_creator_, 100 * 256);
-
- SendStreamDataToPeer(1, "foo", 6, !kFin, &last_packet);
- EXPECT_EQ(PACKET_4BYTE_PACKET_NUMBER,
- QuicPacketCreatorPeer::NextPacketNumberLength(creator_));
- EXPECT_EQ(PACKET_2BYTE_PACKET_NUMBER,
- writer_->header().public_header.packet_number_length);
-
- QuicPacketCreatorPeer::SetPacketNumber(&peer_creator_, 100 * 256 * 256);
-
- SendStreamDataToPeer(1, "bar", 9, !kFin, &last_packet);
- EXPECT_EQ(PACKET_4BYTE_PACKET_NUMBER,
- QuicPacketCreatorPeer::NextPacketNumberLength(creator_));
- EXPECT_EQ(PACKET_4BYTE_PACKET_NUMBER,
- writer_->header().public_header.packet_number_length);
-
- QuicPacketCreatorPeer::SetPacketNumber(&peer_creator_, 100 * 256 * 256 * 256);
-
- SendStreamDataToPeer(1, "foo", 12, !kFin, &last_packet);
- EXPECT_EQ(PACKET_6BYTE_PACKET_NUMBER,
- QuicPacketCreatorPeer::NextPacketNumberLength(creator_));
- EXPECT_EQ(PACKET_4BYTE_PACKET_NUMBER,
- writer_->header().public_header.packet_number_length);
-}
-
TEST_P(QuicConnectionTest, BasicSending) {
EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
QuicPacketNumber last_packet;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698