Let QUIC respect HTTP2 Settings frame. Currently, only SETTINGS_HEADER_TABLE_SIZE is supported. Pro…

net/quic/quic_headers_stream.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_headers_stream.h"
 
 #include <utility>
 
 #include "base/macros.h"
 #include "base/metrics/histogram_macros.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "net/quic/quic_bug_tracker.h"
 #include "net/quic/quic_flags.h"
 #include "net/quic/quic_header_list.h"
 #include "net/quic/quic_spdy_session.h"
 #include "net/quic/quic_time.h"
 #include "net/spdy/spdy_protocol.h"
 
 using base::StringPiece;
 using net::HTTP2;
@@ skipping 113 matching lines @@
                          bool fin) override {
     CloseConnection("SPDY DATA frame received.");
   }
 
   void OnRstStream(SpdyStreamId stream_id,
                    SpdyRstStreamStatus status) override {
     CloseConnection("SPDY RST_STREAM frame received.");
   }
 
   void OnSetting(SpdySettingsIds id, uint8_t flags, uint32_t value) override {
-    CloseConnection("SPDY SETTINGS frame received.");
+    if (!FLAGS_quic_respect_http2_settings_frame) {
+      CloseConnection("SPDY SETTINGS frame received.");
+      return;
+    }
+    switch (id) {
+      case SETTINGS_HEADER_TABLE_SIZE:
+        stream_->UpdateHeaderEncoderTableSize(value);
+        break;
+      // TODO(fayang): Need to support SETTINGS_MAX_HEADER_LIST_SIZE when
+      // clients are actually sending it.
+      default:
+        CloseConnection(
+            "Unsupported field of HTTP/2 SETTINGS frame: " + base::IntToString(id));
+    }
   }
 
   void OnSettingsAck() override {
-    CloseConnection("SPDY SETTINGS frame received.");
+    if (!FLAGS_quic_respect_http2_settings_frame) {
+      CloseConnection("SPDY SETTINGS frame received.");
+    }
   }
 
   void OnSettingsEnd() override {
-    CloseConnection("SPDY SETTINGS frame received.");
+    if (!FLAGS_quic_respect_http2_settings_frame) {
+      CloseConnection("SPDY SETTINGS frame received.");
+    }
   }
 
   void OnPing(SpdyPingId unique_id, bool is_ack) override {
     CloseConnection("SPDY PING frame received.");
   }
 
   void OnGoAway(SpdyStreamId last_accepted_stream_id,
                 SpdyGoAwayStatus status) override {
     CloseConnection("SPDY GOAWAY frame received.");
   }
@@ skipping 314 matching lines @@
           session()->connection()->helper()->GetClock(), std::move(visitor))));
 }
 
 void QuicHeadersStream::SetHpackDecoderDebugVisitor(
     std::unique_ptr<HpackDebugVisitor> visitor) {
   spdy_framer_.SetDecoderHeaderTableDebugVisitor(
       std::unique_ptr<HeaderTableDebugVisitor>(new HeaderTableDebugVisitor(
           session()->connection()->helper()->GetClock(), std::move(visitor))));
 }
 
+void QuicHeadersStream::UpdateHeaderEncoderTableSize(uint32_t value) {
+  spdy_framer_.UpdateHeaderEncoderTableSize(value);
+}
+
 }  // namespace net