Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2102663003: Refactor inlining of recognized methods. (Closed)

Created:
4 years, 5 months ago by Florian Schneider
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor inlining of recognized methods. Move some common code into the FlowGraphInliner to avoid duplication. Also, only emit the receiver class check when necessary in the first place. There is more duplicate code in jit_optimizer.cc and aot_optimizer.cc which is independent of the compilation mode. This CL is just a step. Removed receiver class check for SIMD operations that require unboxing: The unbox operation already checks the argument type. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/a3dcdb35aa269447ca39c809aa6a848a725f1c66

Patch Set 1 #

Patch Set 2 : fixed missing inlining, more cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -238 lines) Patch
M runtime/vm/aot_optimizer.cc View 1 6 chunks +13 lines, -88 lines 0 comments Download
M runtime/vm/flow_graph_inliner.h View 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 4 chunks +99 lines, -0 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 1 15 chunks +13 lines, -150 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Florian Schneider
4 years, 5 months ago (2016-06-27 20:45:20 UTC) #2
Florian Schneider
Stand by - I'm investigating a performance regression caused by this.
4 years, 5 months ago (2016-06-27 22:12:21 UTC) #3
Florian Schneider
PTAL
4 years, 5 months ago (2016-06-28 01:56:48 UTC) #5
Vyacheslav Egorov (Google)
lgtm
4 years, 5 months ago (2016-06-28 12:31:58 UTC) #6
Florian Schneider
4 years, 5 months ago (2016-06-28 18:25:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a3dcdb35aa269447ca39c809aa6a848a725f1c66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698