Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2102613002: infra_paths: keep cache paths super short to avoid long path issues (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

infra_paths: keep cache paths super short to avoid long path issues BUG=623575 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/aa0b3b6bd0111a0fd7aa6151f7b87a9247300cad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M recipe_modules/infra_paths/path_config.py View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Paweł Hajdan Jr.
4 years, 5 months ago (2016-06-27 15:52:39 UTC) #2
emso
lgtm
4 years, 5 months ago (2016-06-27 16:05:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102613002/1
4 years, 5 months ago (2016-06-27 16:05:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/aa0b3b6bd0111a0fd7aa6151f7b87a9247300cad
4 years, 5 months ago (2016-06-27 16:08:46 UTC) #7
nodir
were bots in entire fleet cleaned up after this change?
4 years, 5 months ago (2016-06-27 19:07:57 UTC) #9
nodir
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2100793004/ by nodir@chromium.org. ...
4 years, 5 months ago (2016-06-27 21:07:07 UTC) #10
nodir
4 years, 5 months ago (2016-06-27 21:14:57 UTC) #11
Message was sent while issue was closed. 
On 2016/06/27 21:07:07, nodir wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2100793004/ by mailto:nodir@chromium.org.
> 
> The reason for reverting is: /b/cache dir on slaves were not cleaned up and
now
> disk alerts are firing
> 
> please come up with a cleanup strategy before re-landing this CL.

perhaps /b/cache needs to be renamed to /b/c

Powered by Google App Engine
This is Rietveld 408576698