Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 210253003: Make data: urls always parse async (Closed)

Created:
6 years, 9 months ago by eseidel
Modified:
6 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Make data: urls always parse async Turns out Chrome has long had the behavior of issuing loads and delivering load events async for data: urls, but not actually doing the parsing async. This changes makes the parsing of data:text/html content always async. NOTE: The new async test (loader/iframe-sync-loads.html) does not change before before/after this test, it's there to confirm that we were already behaving async with regards to when the content appeared in the iframe. This finally makes it possible to take a JS string and run it through the HTML parser async. I'll fix <iframe srcdoc> to also be async in a follow-up patch. I wrote a test to check sync/async behavior of various loading methods for iframes. Gecko has async behavior for all 3 of these cases in my test, where as Chrome on Linux has sync behavior for javascript: This is covered by 3 additional tests: fast/dom/document-contentType-data-uri.html: - text/html content is now async, matches FF accessibility/loading-iframe-sends-notification.html - had to re-write this test to not assume that the iframe would be laid out before its onload was fired. scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html - This was hitting crbug.com/365509 which I worked around by calling setUseMockScrollbars earlier. browser_tests should have been fixed to expect this change in https://codereview.chromium.org/257723002/ BUG=308321, 365509 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172401

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Fix failing tests #

Total comments: 2

Patch Set 4 : Hacky fix for AX test #

Patch Set 5 : Fix fast/events/drag-and-drop-autoscroll-inner-frame.html #

Patch Set 6 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -38 lines) Patch
M LayoutTests/accessibility/loading-iframe-sends-notification.html View 1 2 3 1 chunk +17 lines, -23 lines 0 comments Download
M LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/document-contentType-data-uri-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/drag-and-drop-autoscroll-inner-frame.html View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/html5lib/resources/runner.js View 1 chunk +0 lines, -3 lines 0 comments Download
A LayoutTests/loader/iframe-sync-loads.html View 1 1 chunk +59 lines, -0 lines 0 comments Download
A LayoutTests/loader/iframe-sync-loads-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/frame/Settings.in View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLParserOptions.cpp View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 48 (0 generated)
eseidel
6 years, 9 months ago (2014-03-25 16:59:20 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-25 18:16:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/210253003/1
6 years, 9 months ago (2014-03-25 18:16:36 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 18:47:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-25 18:47:51 UTC) #5
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-03-31 17:37:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/210253003/1
6 years, 8 months ago (2014-03-31 17:37:46 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 18:14:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-03-31 18:14:29 UTC) #9
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-02 19:36:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/210253003/1
6 years, 8 months ago (2014-04-02 19:36:49 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 20:09:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-02 20:09:41 UTC) #13
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-21 17:57:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/210253003/1
6 years, 8 months ago (2014-04-21 17:57:39 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-21 18:33:48 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-21 18:33:49 UTC) #17
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-21 20:01:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/210253003/80001
6 years, 8 months ago (2014-04-21 20:01:25 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-21 20:34:22 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-21 20:34:23 UTC) #21
eseidel
PTAL. Dominic, please check the AX test.
6 years, 8 months ago (2014-04-22 20:01:24 UTC) #22
dmazzoni
lgtm for LayoutTests/accessibility https://codereview.chromium.org/210253003/diff/100001/LayoutTests/accessibility/loading-iframe-sends-notification.html File LayoutTests/accessibility/loading-iframe-sends-notification.html (right): https://codereview.chromium.org/210253003/diff/100001/LayoutTests/accessibility/loading-iframe-sends-notification.html#newcode39 LayoutTests/accessibility/loading-iframe-sends-notification.html:39: // Ignore this notification if it's ...
6 years, 8 months ago (2014-04-22 20:41:23 UTC) #23
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-22 22:05:17 UTC) #24
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-22 22:07:58 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/210253003/100001
6 years, 8 months ago (2014-04-22 22:08:20 UTC) #26
eseidel
The CQ bit was unchecked by eseidel@chromium.org
6 years, 8 months ago (2014-04-22 22:09:08 UTC) #27
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-22 22:09:08 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/210253003/100001
6 years, 8 months ago (2014-04-22 22:09:39 UTC) #29
eseidel
Turns out I haven't quite fixed the AX test. Changing it to check for undefined ...
6 years, 8 months ago (2014-04-22 22:17:06 UTC) #30
eseidel
The CQ bit was unchecked by eseidel@chromium.org
6 years, 8 months ago (2014-04-22 22:17:10 UTC) #31
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-22 22:29:38 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/210253003/120001
6 years, 8 months ago (2014-04-22 22:29:59 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 23:37:43 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-22 23:37:44 UTC) #35
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-23 00:18:19 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/210253003/120001
6 years, 8 months ago (2014-04-23 00:18:41 UTC) #37
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 01:35:17 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-23 01:35:18 UTC) #39
eseidel
Looks like a real flake in dbg builds: https://chromium.googlesource.com/chromium/blink.git/+/f60ed4a0fdfbefd37672292bd08a3fd28157ee9a/LayoutTests/fast/events/drag-and-drop-autoscroll-inner-frame.html Will fix.
6 years, 8 months ago (2014-04-23 01:40:47 UTC) #40
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-04-23 17:30:16 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/210253003/140001
6 years, 8 months ago (2014-04-23 17:30:28 UTC) #42
commit-bot: I haz the power
Change committed as 172401
6 years, 8 months ago (2014-04-23 21:09:23 UTC) #43
aboxhall
A revert of this CL has been created in https://codereview.chromium.org/259443002/ by aboxhall@chromium.org. The reason for ...
6 years, 8 months ago (2014-04-23 23:08:04 UTC) #44
eseidel
I've posted a fix for browser_tests in https://codereview.chromium.org/257723002/ Once that lands I can re-land this.
6 years, 8 months ago (2014-04-24 23:07:17 UTC) #45
eseidel
I failed to fully fix the browser_tests issues. I've broken just the LayoutTest parts of ...
6 years, 7 months ago (2014-04-28 18:10:19 UTC) #46
dmazzoni
Want to close this? Removing myself as reviewer for now.
6 years, 4 months ago (2014-08-11 05:37:57 UTC) #47
eseidel
6 years, 4 months ago (2014-08-11 05:51:12 UTC) #48
I believe dcheng finished this work.

Powered by Google App Engine
This is Rietveld 408576698