infra_paths: enable persistent cache also on Windows

infra_paths: enable persistent cache also on Windows

BUG=584079, 459840, 593999, 596887
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/c2054c2fb0e5af75ffa1ac1305b3fa805f73ae4a

[Paweł Hajdan Jr., 2016-06-27 10:24:21]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 10:24:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 10:30:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 10:30:24]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[Paweł Hajdan Jr., 2016-06-27 10:50:00]

phajdan.jr@chromium.org changed reviewers:
+ emso@chromium.org, sergiyb@chromium.org, tandrii@chromium.org

[Sergiy Byelozyorov, 2016-06-27 10:58:35]

lgtm

https://codereview.chromium.org/2102503002/diff/40001/recipe_modules/infra_pa...
File recipe_modules/infra_paths/path_config.py (right):

https://codereview.chromium.org/2102503002/diff/40001/recipe_modules/infra_pa...
recipe_modules/infra_paths/path_config.py:44: c.base_paths['cache'] = b_dir +
('cache', 'chromium')
Is it valid to add lists and tuples? Maybe better change second argument to a
list or convert first to a tuple.

[Paweł Hajdan Jr., 2016-06-27 10:59:08]

https://codereview.chromium.org/2102503002/diff/40001/recipe_modules/infra_pa...
File recipe_modules/infra_paths/path_config.py (right):

https://codereview.chromium.org/2102503002/diff/40001/recipe_modules/infra_pa...
recipe_modules/infra_paths/path_config.py:44: c.base_paths['cache'] = b_dir +
('cache', 'chromium')
On 2016/06/27 at 10:58:35, Sergiy Byelozyorov wrote:
> Is it valid to add lists and tuples? Maybe better change second argument to a
list or convert first to a tuple.

It's already a tuple.

[Paweł Hajdan Jr., 2016-06-27 10:59:11]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-06-27 10:59:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 11:02:34]

Description was changed from

==========
infra_paths: enable persistent cache also on Windows

BUG=584079, 459840, 593999, 596887
==========

to

==========
infra_paths: enable persistent cache also on Windows

BUG=584079, 459840, 593999, 596887

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/c2054c2fb0e5af...
==========

[commit-bot: I haz the power, 2016-06-27 11:02:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/c2054c2fb0e5af...

[Sergiy Byelozyorov, 2016-06-27 11:26:49]

https://codereview.chromium.org/2102503002/diff/40001/recipe_modules/infra_pa...
File recipe_modules/infra_paths/path_config.py (right):

https://codereview.chromium.org/2102503002/diff/40001/recipe_modules/infra_pa...
recipe_modules/infra_paths/path_config.py:44: c.base_paths['cache'] = b_dir +
('cache', 'chromium')
On 2016/06/27 10:59:07, Paweł Hajdan Jr. wrote:
> On 2016/06/27 at 10:58:35, Sergiy Byelozyorov wrote:
> > Is it valid to add lists and tuples? Maybe better change second argument to
a
> list or convert first to a tuple.
> 
> It's already a tuple.

Indeed, thanks for pointing this out. I thought using [:-1] operation
automatically converts things to a list.