[gn] Add remaining executables to gn

[gn] Add remaining executables to gn

This adds generate-bytecode-expectations and parser_shell.

BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/1deca4bafd0972784fc31f7f254b30de4f55f26f
Cr-Commit-Position: refs/heads/master@{#37287}

[Michael Achenbach, 2016-06-27 08:26:55]

Description was changed from

==========
[gn] Add remaining executables to gn

BUG=
==========

to

==========
[gn] Add remaining executables to gn

This adds generate-bytecode-expectations and parser_shell.

BUG=chromium:474921
==========

[Michael Achenbach, 2016-06-27 08:26:55]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-06-27 08:28:59]

Description was changed from

==========
[gn] Add remaining executables to gn

This adds generate-bytecode-expectations and parser_shell.

BUG=chromium:474921
==========

to

==========
[gn] Add remaining executables to gn

This adds generate-bytecode-expectations and parser_shell.

BUG=chromium:474921
NOTRY=true
==========

[Michael Achenbach, 2016-06-27 08:29:22]

PTAL

[jochen (gone - plz use gerrit), 2016-06-27 08:57:13]

lgtm

[Michael Achenbach, 2016-06-27 09:11:57]

See patch 3.

https://codereview.chromium.org/2102483002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2102483002/diff/40001/BUILD.gn#newcode2217
BUILD.gn:2217: ":external_config",
I guess the comment on the left is wrong for most of our executables. It seems
to work anyway, except for parser_shell. For external_config to be applied
automatically, v8 needs to be a public_deps.

Will try to unify/clean up a bunch of these things in a follow up.

[jochen (gone - plz use gerrit), 2016-06-27 09:16:56]

On 2016/06/27 at 09:11:57, machenbach wrote:
> See patch 3.
> 
> https://codereview.chromium.org/2102483002/diff/40001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2102483002/diff/40001/BUILD.gn#newcode2217
> BUILD.gn:2217: ":external_config",
> I guess the comment on the left is wrong for most of our executables. It seems
to work anyway, except for parser_shell. For external_config to be applied
automatically, v8 needs to be a public_deps.
> 
> Will try to unify/clean up a bunch of these things in a follow up.

I guess parser shell (in gyp) just doesn't work at all in a component build
(while the other executables actually do) and we need a similar thing as we have
for cctest to link against the v8 source set directly in component builds

[Michael Achenbach, 2016-06-27 09:19:42]

On 2016/06/27 09:16:56, jochen wrote:
> On 2016/06/27 at 09:11:57, machenbach wrote:
> > See patch 3.
> > 
> > https://codereview.chromium.org/2102483002/diff/40001/BUILD.gn
> > File BUILD.gn (right):
> > 
> > https://codereview.chromium.org/2102483002/diff/40001/BUILD.gn#newcode2217
> > BUILD.gn:2217: ":external_config",
> > I guess the comment on the left is wrong for most of our executables. It
seems
> to work anyway, except for parser_shell. For external_config to be applied
> automatically, v8 needs to be a public_deps.
> > 
> > Will try to unify/clean up a bunch of these things in a follow up.
> 
> I guess parser shell (in gyp) just doesn't work at all in a component build
> (while the other executables actually do) and we need a similar thing as we
have
> for cctest to link against the v8 source set directly in component builds

Hmm, isn't the parser shell part of the all target in gyp as well? E.g. I can
see it being built on many builders. And we have shared_library builders that
would fail then, wouldn't they?

[jochen (gone - plz use gerrit), 2016-06-27 09:22:12]

i guess it builds but can't run?

[Michael Achenbach, 2016-06-27 09:34:45]

Hmm - tried locally - can't be built either. Will try the fix. Why our shared
lib builds work is still a mystery. Maybe it's not built there.

[Michael Achenbach, 2016-06-27 09:37:00]

Works with fix in patch 4. Taking back my previous comment and change about the
external_config...

[jochen (gone - plz use gerrit), 2016-06-27 09:40:32]

lgtm

[Michael Achenbach, 2016-06-27 10:48:40]

Looking at the output of android_clang_dbg_recipe, we need both, the component
build fix and the external_config. Will add that back...

[jochen (gone - plz use gerrit), 2016-06-27 11:34:31]

lgtm

[jochen (gone - plz use gerrit), 2016-06-27 11:35:09]

On 2016/06/27 at 11:34:31, jochen wrote:
> lgtm

(cctest also depends on both configs)

[Michael Achenbach, 2016-06-27 11:53:08]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-06-27 11:53:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 11:55:43]

Description was changed from

==========
[gn] Add remaining executables to gn

This adds generate-bytecode-expectations and parser_shell.

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Add remaining executables to gn

This adds generate-bytecode-expectations and parser_shell.

BUG=chromium:474921
NOTRY=true
==========

[commit-bot: I haz the power, 2016-06-27 11:55:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-27 11:57:59]

Description was changed from

==========
[gn] Add remaining executables to gn

This adds generate-bytecode-expectations and parser_shell.

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Add remaining executables to gn

This adds generate-bytecode-expectations and parser_shell.

BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/1deca4bafd0972784fc31f7f254b30de4f55f26f
Cr-Commit-Position: refs/heads/master@{#37287}
==========

[commit-bot: I haz the power, 2016-06-27 11:58:00]

Patchset 5 (id:??) landed as
https://crrev.com/1deca4bafd0972784fc31f7f254b30de4f55f26f
Cr-Commit-Position: refs/heads/master@{#37287}