Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

Issue 2102453003: [DevTools] Move collectionEntries to internalProperties in protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
index a8e7637f303e259cb9701854583c27f775138862..25ace1408ebf78c4761b431c1d1323398f79abcd 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
@@ -98,8 +98,8 @@ public:
void setAsyncCallStackDepth(V8DebuggerAgentImpl*, int);
v8::MaybeLocal<v8::Value> functionScopes(v8::Local<v8::Function>);
+ v8::MaybeLocal<v8::Array> internalProperties(v8::Local<v8::Context>, v8::Local<v8::Value>);
v8::Local<v8::Value> generatorObjectDetails(v8::Local<v8::Object>&);
- v8::Local<v8::Value> collectionEntries(v8::Local<v8::Object>&);
v8::Isolate* isolate() const { return m_isolate; }
V8DebuggerClient* client() { return m_client; }
@@ -156,6 +156,8 @@ private:
void handleV8AsyncTaskEvent(v8::Local<v8::Context>, v8::Local<v8::Object> executionState, v8::Local<v8::Object> eventData);
+ v8::Local<v8::Value> collectionEntries(v8::Local<v8::Object>);
+
v8::Isolate* m_isolate;
V8DebuggerClient* m_client;
using ContextsByGroupMap = protocol::HashMap<int, std::unique_ptr<ContextByIdMap>>;

Powered by Google App Engine
This is Rietveld 408576698