Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 2102453003: [DevTools] Move collectionEntries to internalProperties in protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
index fb1862735d65a79393a6444202f86de09bb182b5..5dd6a30b1fb727086d1ce736d0cb90d3391a76f9 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
@@ -314,14 +314,6 @@ WebInspector.RemoteObject.prototype = {
generatorObjectDetails: function(callback)
{
callback(null);
- },
-
- /**
- * @param {function(?Array<!DebuggerAgent.CollectionEntry>)} callback
- */
- collectionEntries: function(callback)
- {
- callback(null);
}
}
@@ -894,19 +886,6 @@ WebInspector.RemoteObjectImpl.prototype = {
this._debuggerModel.generatorObjectDetails(this, callback);
},
- /**
- * @override
- * @param {function(?Array.<!DebuggerAgent.CollectionEntry>)} callback
- */
- collectionEntries: function(callback)
- {
- if (!this._objectId) {
- callback(null);
- return;
- }
- this._debuggerModel.getCollectionEntries(this._objectId, callback);
- },
-
__proto__: WebInspector.RemoteObject.prototype
};
@@ -1588,30 +1567,3 @@ WebInspector.RemoteFunction.prototype = {
return this._object;
}
}
-
-/**
- * @constructor
- * @extends {WebInspector.LocalJSONObject}
- * @param {*} value
- */
-WebInspector.MapEntryLocalJSONObject = function(value)
-{
- WebInspector.LocalJSONObject.call(this, value);
-}
-
-WebInspector.MapEntryLocalJSONObject.prototype = {
- /**
- * @override
- * @return {string}
- */
- get description()
- {
- if (!this._cachedDescription) {
- var children = this._children();
- this._cachedDescription = "{" + this._formatValue(children[0].value) + " => " + this._formatValue(children[1].value) + "}";
- }
- return this._cachedDescription;
- },
-
- __proto__: WebInspector.LocalJSONObject.prototype
-}

Powered by Google App Engine
This is Rietveld 408576698