[DevTools] Move collectionEntries to internalProperties in protocol

third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 554 matching lines @@
                     var setterProperty = new WebInspector.RemoteObjectProperty("set " + property.name, property.setter);
                     setterProperty.parentObject = value;
                     treeNode.appendChild(new WebInspector.ObjectPropertyTreeElement(setterProperty));
                 }
             }
         } else {
             property.parentObject = value;
             treeNode.appendChild(new WebInspector.ObjectPropertyTreeElement(property));
         }
     }
+    var entries = null;
     if (internalProperties) {
         for (var i = 0; i < internalProperties.length; i++) {
+            if (internalProperties[i].name === "[[Entries]]") {
+                entries = internalProperties[i].value;
+                continue;
+            }
             internalProperties[i].parentObject = value;
             treeNode.appendChild(new WebInspector.ObjectPropertyTreeElement(internalProperties[i]));
         }
     }
     if (value && value.type === "function") {
         // Whether function has TargetFunction internal property.
         // This is a simple way to tell that the function is actually a bound function (we are not told).
         // Bound function never has inner scope and doesn't need corresponding UI node.
         var hasTargetFunction = false;
 
         if (internalProperties) {
             for (var i = 0; i < internalProperties.length; i++) {
                 if (internalProperties[i].name === "[[TargetFunction]]") {
                     hasTargetFunction = true;
                     break;
                 }
             }
         }
         if (!hasTargetFunction)
             treeNode.appendChild(new WebInspector.FunctionScopeMainTreeElement(value));
     }
-    if (value && value.type === "object" && (value.subtype === "map" || value.subtype === "set" || value.subtype === "iterator"))
-        treeNode.appendChild(new WebInspector.CollectionEntriesMainTreeElement(value));
+    if (entries)
+        treeNode.appendChild(new WebInspector.CollectionEntriesMainTreeElement(entries));
 
     WebInspector.ObjectPropertyTreeElement._appendEmptyPlaceholderIfNeeded(treeNode, emptyPlaceholder);
 }
 
 /**
  * @param {!TreeElement} treeNode
  * @param {?string=} emptyPlaceholder
  */
 WebInspector.ObjectPropertyTreeElement._appendEmptyPlaceholderIfNeeded = function(treeNode, emptyPlaceholder)
 {
@@ skipping 113 matching lines @@
 
         this._remoteObject.functionDetails(didGetDetails.bind(this));
     },
 
     __proto__: TreeElement.prototype
 }
 
 /**
  * @constructor
  * @extends {TreeElement}
- * @param {!WebInspector.RemoteObject} remoteObject
+ * @param {!WebInspector.RemoteObject} entries
  */
-WebInspector.CollectionEntriesMainTreeElement = function(remoteObject)
+WebInspector.CollectionEntriesMainTreeElement = function(entries)
 {
     TreeElement.call(this, "<entries>", true);
     this.toggleOnClick = true;
     this.selectable = false;
-    this._remoteObject = remoteObject;
+    this._entries = entries;
     this.expand();
 }
 
 WebInspector.CollectionEntriesMainTreeElement.prototype = {
     onpopulate: function()
     {
         /**
-         * @param {?Array.<!DebuggerAgent.CollectionEntry>} entries
+         * @param {?Array<!WebInspector.RemoteObjectProperty>} entries
          * @this {WebInspector.CollectionEntriesMainTreeElement}
          */
-        function didGetCollectionEntries(entries)
+        function populateWithEntries(entries)
         {
             if (!entries)
                 return;
             this.removeChildren();
 
             var entriesLocalObject = [];
-            var runtimeModel = this._remoteObject.target().runtimeModel;
-            for (var i = 0; i < entries.length; ++i) {
-                var entry = entries[i];
-                if (entry.key) {
-                    entriesLocalObject.push(new WebInspector.MapEntryLocalJSONObject({
-                        key: runtimeModel.createRemoteObject(entry.key),
-                        value: runtimeModel.createRemoteObject(entry.value)
-                    }));
-                } else {
-                    entriesLocalObject.push(runtimeModel.createRemoteObject(entry.value));
-                }
+            for (var entry of entries) {
+                var name = entry.name;
+                // Array index check according to the ES5-15.4.
+                if (String(name >>> 0) !== name || name >>> 0 === 0xffffffff)

[dgozman, 2016/06/28 01:20:46]

Why do we have this check?

[kozy, 2016/06/28 18:41:49]

getProperties return __proto__ and length properties for array of entries, we
need to filter only entries.

[dgozman, 2016/06/28 18:58:08]

Let's have a variable |var isArrayIndex| and check |if (!isArrayIndex)|.

+                    continue;
+                var value = entry.value;
+                entriesLocalObject.push(new WebInspector.EntryRemoteObject(value.target(), value.objectId, value.type, value.subtype, value.value, value.description, value.preview));
             }
             WebInspector.ObjectPropertyTreeElement._populate(this, WebInspector.RemoteObject.fromLocalObject(entriesLocalObject), true, WebInspector.UIString("No Entries"));
             this.title = "<entries>[" + entriesLocalObject.length + "]";
         }
 
-        this._remoteObject.collectionEntries(didGetCollectionEntries.bind(this));
+        this._entries.getOwnProperties(populateWithEntries.bind(this), true);
     },
 
     __proto__: TreeElement.prototype
 }
 
 /**
  * @constructor
  * @extends {TreeElement}
  * @param {string} title
  * @param {!WebInspector.RemoteObject} remoteObject
@@ skipping 626 matching lines @@
 
             result = currentName + (result ? "." + result : "");
             current = current.parent;
         }
         var treeOutlineId = treeElement.treeOutline[WebInspector.ObjectPropertiesSectionExpandController._treeOutlineId];
         result = treeOutlineId + (result ? ":" + result : "");
         treeElement[WebInspector.ObjectPropertiesSectionExpandController._cachedPathSymbol] = result;
         return result;
     }
 }