Issue 2102443002: [GN] content_unittests should depeng on //content/common

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2102443002: [GN] content_unittests should depeng on //content/common (Closed)

Created:
4 years, 5 months ago by tapted

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[GN] content_unittests should depeng on //content/common Add missing content_unittests dep on //content/common (gn only) BUG=623449

Patch Set 1 #

Patch Set 2 : Fix mac #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
M	content/common/BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/sandbox_init_mac.cc	View	1	2 chunks	+11 lines, -8 lines	0 comments	Download
M	content/public/common/content_client.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tapted

4 years, 5 months ago (2016-06-27 05:05:32 UTC) #1

Description was changed from

==========
[GN] content_unittests should depeng on //content/common

Add missing content_unittests dep on //content/common (gn only)

BUG=
==========

to

==========
[GN] content_unittests should depeng on //content/common

Add missing content_unittests dep on //content/common (gn only)

BUG=623449
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages