Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: tools/perf/benchmarks/v8.py

Issue 2102433004: Revert of Disabled v8.top_25_smooth/smoothness.top_25_smooth on mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/smoothness.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import re 5 import re
6 6
7 from core import path_util 7 from core import path_util
8 from core import perf_benchmark 8 from core import perf_benchmark
9 from page_sets import google_pages 9 from page_sets import google_pages
10 10
(...skipping 11 matching lines...) Expand all
22 22
23 def CreateV8TimelineBasedMeasurementOptions(): 23 def CreateV8TimelineBasedMeasurementOptions():
24 category_filter = tracing_category_filter.CreateMinimalOverheadFilter() 24 category_filter = tracing_category_filter.CreateMinimalOverheadFilter()
25 category_filter.AddIncludedCategory('v8') 25 category_filter.AddIncludedCategory('v8')
26 category_filter.AddIncludedCategory('blink.console') 26 category_filter.AddIncludedCategory('blink.console')
27 options = timeline_based_measurement.Options(category_filter) 27 options = timeline_based_measurement.Options(category_filter)
28 options.SetTimelineBasedMetric('executionMetric') 28 options.SetTimelineBasedMetric('executionMetric')
29 return options 29 return options
30 30
31 31
32 @benchmark.Disabled('win', # crbug.com/416502 32 @benchmark.Disabled('win') # crbug.com/416502
33 'mac') # crbug.com/623570
34 class V8Top25(perf_benchmark.PerfBenchmark): 33 class V8Top25(perf_benchmark.PerfBenchmark):
35 """Measures V8 GC metrics on the while scrolling down the top 25 web pages. 34 """Measures V8 GC metrics on the while scrolling down the top 25 web pages.
36 35
37 http://www.chromium.org/developers/design-documents/rendering-benchmarks""" 36 http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
38 test = v8_gc_times.V8GCTimes 37 test = v8_gc_times.V8GCTimes
39 page_set = page_sets.V8Top25SmoothPageSet 38 page_set = page_sets.V8Top25SmoothPageSet
40 39
41 @classmethod 40 @classmethod
42 def ShouldDisable(cls, possible_browser): # http://crbug.com/597656 41 def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
43 return (possible_browser.browser_type == 'reference' and 42 return (possible_browser.browser_type == 'reference' and
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 def Name(cls): 296 def Name(cls):
298 return 'v8.google' 297 return 'v8.google'
299 298
300 @classmethod 299 @classmethod
301 def ShouldDisable(cls, possible_browser): 300 def ShouldDisable(cls, possible_browser):
302 return cls.IsSvelte(possible_browser) # http://crbug.com/596556 301 return cls.IsSvelte(possible_browser) # http://crbug.com/596556
303 302
304 @classmethod 303 @classmethod
305 def ShouldTearDownStateAfterEachStoryRun(cls): 304 def ShouldTearDownStateAfterEachStoryRun(cls):
306 return True 305 return True
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/smoothness.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698