Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2678)

Unified Diff: chrome/browser/notifications/arc_application_notifier_source_chromeos.cc

Issue 2102433002: Filter out ARC notifiers that are not shown in launcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Filter out Android system packages from Chrome OS notification settings. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/arc/arc_app_list_prefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
diff --git a/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc b/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
index 108a74cbf30dd5a7d23c7812afce7f7e3cfcd6a6..6e744276cface32a636dea2e2b5cb739ac2acc57 100644
--- a/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
+++ b/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
@@ -52,6 +52,10 @@ ArcApplicationNotifierSourceChromeOS::GetNotifierList(Profile* profile) {
if (package_to_app_ids_.count(app->package_name))
continue;
+ const auto package = app_list->GetPackage(app->package_name);
+ if (!package || package->system)
+ continue;
xiyuan 2016/06/30 14:43:03 nit: wrong indent ?
hirono 2016/07/01 07:19:05 Done.
+
// Load icons for notifier.
std::unique_ptr<ArcAppIcon> icon(
new ArcAppIcon(profile, app_id,
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/arc/arc_app_list_prefs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698