Issue 210243005: DevTools: polish Mac UI (borders, alignment, line heights, images).

Issue 210243005: DevTools: polish Mac UI (borders, alignment, line heights, images). (Closed)

Created:
6 years, 9 months ago by pfeldman

Modified:
6 years, 8 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: polish Mac UI (borders, alignment, line heights, images). TBR=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170181

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -21 lines)			Patch
M	Source/devtools/front_end/BreakpointsSidebarPane.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/SourcesPanel.js	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/breakpointsList.css	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/elementsPanel.css	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/inspector.css	View		5 chunks	+8 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/navigatorView.css	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/sidebarPane.css	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sourcesPanel.css	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/splitView.css	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/tabbedPane.css	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/210243005/diff/1/Source/devtools/front_end/BreakpointsSidebarPane.js File Source/devtools/front_end/BreakpointsSidebarPane.js (right): https://codereview.chromium.org/210243005/diff/1/Source/devtools/front_end/BreakpointsSidebarPane.js#newcode530 Source/devtools/front_end/BreakpointsSidebarPane.js:530: this._createCategory(WebInspector.UIString("Drag / drop"), true, ["dragenter", "dragover", "dragleave", "drop"]); Yes, ...

6 years, 9 months ago (2014-03-25 20:54:51 UTC) #2

pfeldman

6 years, 8 months ago (2014-03-27 14:21:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r170181 (presubmit successful).

Expand Messages | Collapse Messages