Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2102423002: Move |updateStyleAndLayout()| call from |updateTextLayoutObject()| to call sites (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move |updateStyleAndLayout()| call from |updateTextLayoutObject()| to call sites This patch moves |updateStyleAndLayout()| call from |updateTextLayoutObject()| in |Text| to call sites for a preparation of getting rid of |DeprecatedRecalcStyleImmediatlelyForEditing|. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/ab6f59df8c2d75228b99d5036cc66f304dd737d0 Cr-Commit-Position: refs/heads/master@{#403073}

Patch Set 1 : 2016-06-29T16:59:47 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-06-29 08:43:09 UTC) #4
yoichio
lgtm
4 years, 5 months ago (2016-06-30 01:57:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102423002/1
4 years, 5 months ago (2016-06-30 02:29:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 02:34:43 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 02:34:53 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 02:35:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab6f59df8c2d75228b99d5036cc66f304dd737d0
Cr-Commit-Position: refs/heads/master@{#403073}

Powered by Google App Engine
This is Rietveld 408576698