Add/remove spell checking markers in text inputs depending on focus.

Source/web/EditorClientImpl.cpp

 /*
  * Copyright (C) 2006, 2007 Apple, Inc.  All rights reserved.
  * Copyright (C) 2012 Google, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 82 matching lines @@
 bool EditorClientImpl::isSelectTrailingWhitespaceEnabled()
 {
     if (m_webView->page())
         return m_webView->page()->settings()->selectTrailingWhitespaceEnabled();
     return false;
 }
 
 bool EditorClientImpl::shouldSpellcheckByDefault()
 {
     // Spellcheck should be enabled for all editable areas (such as textareas,
-    // contentEditable regions, and designMode docs), except text inputs.
+    // contentEditable regions, designMode docs and inputs).
     const Frame* frame = m_webView->focusedWebCoreFrame();
     if (!frame)
         return false;
     const Editor* editor = frame->editor();
     if (!editor)
         return false;
     if (editor->isSpellCheckingEnabledInFocusedNode())
         return true;

[tony, 2013/07/31 20:59:29]

It looks like we already spellcheck inputs by default.  I think this is because
of this condition: if the spellcheck attribute is not set anywhere, we return
true here.

I'm not sure what the purpose of the change to this function is.

It's also weird that if the spellcheck attribute is false, we can still return
true from this function.  I guess we check the attribute somewhere else.

     const Document* document = frame->document();
     if (!document)
         return false;
     const Element* element = document->focusedElement();
     // If |element| is null, we default to allowing spellchecking. This is done
     // in order to mitigate the issue when the user clicks outside the textbox,
     // as a result of which |element| becomes null, resulting in all the spell
     // check markers being deleted. Also, the Frame will decide not to do
     // spellchecking if the user can't edit - so returning true here will not
     // cause any problems to the Frame's behavior.
     if (!element)
         return true;
     const RenderObject* renderer = element->renderer();
     if (!renderer)
         return false;
 
-    return !renderer->isTextField();
+    return true;
 }
 
 bool EditorClientImpl::isContinuousSpellCheckingEnabled()
 {
     if (m_spellCheckThisFieldStatus == SpellCheckForcedOff)
         return false;
     if (m_spellCheckThisFieldStatus == SpellCheckForcedOn)
         return true;
     return shouldSpellcheckByDefault();
 }
@@ skipping 624 matching lines @@
 #endif
 }
 
 void EditorClientImpl::willSetInputMethodState()
 {
     if (m_webView->client())
         m_webView->client()->resetInputMethod();
 }
 
 } // namesace WebKit