Chromium Code Reviews Chromium Code Reviews
Issue 21024004:
Add/remove spell checking markers in text inputs depending on focus. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 <link rel="stylesheet" href="../../fast/js/resources/js-test-style.css"> | 4 <link rel="stylesheet" href="../../fast/js/resources/js-test-style.css"> |
| 5 <script src="../../fast/js/resources/js-test-pre.js"></script> | 5 <script src="../../fast/js/resources/js-test-pre.js"></script> |
| 6 <script src="../editing.js"></script> | 6 <script src="../editing.js"></script> |
| 7 <style> | 7 <style> |
| 8 .editing { | 8 .editing { |
| 9 border: 2px solid red; | 9 border: 2px solid red; |
| 10 padding: 6px; | 10 padding: 6px; |
| (...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 204 } | 204 } |
| 205 | 205 |
| 206 function verifyExistenceOfMarkers(elem, tweakKind) { | 206 function verifyExistenceOfMarkers(elem, tweakKind) { |
| 207 if (!window.internals) | 207 if (!window.internals) |
| 208 return true; | 208 return true; |
| 209 | 209 |
| 210 switch (tweakKind) { | 210 switch (tweakKind) { |
| 211 case 'delete': | 211 case 'delete': |
| 212 return true; | 212 return true; |
| 213 case 'move': | 213 case 'move': |
| 214 // In move, marker should be there. | 214 // In move, marker should be there unless it's input which is moved. |
|
please use gerrit instead
2013/07/30 21:32:00
This sentence is not clear. Please explain in more
| |
| 215 if (elem instanceof HTMLInputElement && elem !=document.activeElement) | |
|
please use gerrit instead
2013/07/30 21:32:00
Please add a space after !=.
| |
| 216 return true; | |
| 215 var markerNum = internals.markerCountForNode(findFirstTextNode(elem), "s pelling"); | 217 var markerNum = internals.markerCountForNode(findFirstTextNode(elem), "s pelling"); |
| 216 if (markerNum != 3) | 218 if (markerNum != 3) |
| 217 return false; | 219 return false; |
| 218 for (var i = 0; i < 3; ++i) { | 220 for (var i = 0; i < 3; ++i) { |
| 219 var range = internals.markerRangeForNode(findFirstTextNode(elem), "s pelling", i); | 221 var range = internals.markerRangeForNode(findFirstTextNode(elem), "s pelling", i); |
| 220 if (range.toString() != "zz") | 222 if (range.toString() != "zz") |
| 221 return false; | 223 return false; |
| 222 } | 224 } |
| 223 return true; | 225 return true; |
| 224 case 'mutate': | 226 case 'mutate': |
| 225 // In mutation, there aren't markers. | 227 // In mutation, there aren't markers. |
| 226 return internals.markerCountForNode(findFirstTextNode(elem), "spelling") == 0; | 228 return internals.markerCountForNode(findFirstTextNode(elem), "spelling") == 0; |
| 227 default: | 229 default: |
| 228 testFailed('Unknown kind of tweak'); | 230 testFailed('Unknown kind of tweak'); |
| 229 return true; | 231 return true; |
| 230 } | 232 } |
| 231 } | 233 } |
| 232 | 234 |
| 233 doTestIfAny(); | 235 doTestIfAny(); |
| 234 | 236 |
| 235 var successfullyParsed = true; | 237 var successfullyParsed = true; |
| 236 </script> | 238 </script> |
| 237 <script src="../../fast/js/resources/js-test-post.js"></script> | 239 <script src="../../fast/js/resources/js-test-post.js"></script> |
| 238 </body> | 240 </body> |
| 239 </html> | 241 </html> |
| OLD | NEW |
