Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2102383002: [Extensions] Add metrics for API binding generation time (Closed)

Created:
4 years, 5 months ago by Devlin
Modified:
4 years, 5 months ago
Reviewers:
lazyboy, Mark P
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add metrics for API binding generation time Extension API bindings are generated through some fancy javascript code, but it's probably pretty slow by comparison to other mechanisms we're looking at. Add UMA for the generation times so we have a better picture. BUG=608561 Committed: https://crrev.com/95cbe926faeb42e0f4fcfa3c42c9cba95e77e4e5 Cr-Commit-Position: refs/heads/master@{#402969}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mark's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M extensions/renderer/module_system.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Devlin
Istiaque and Mark, can you take a look?
4 years, 5 months ago (2016-06-29 00:55:12 UTC) #3
Mark P
https://codereview.chromium.org/2102383002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2102383002/diff/1/tools/metrics/histograms/histograms.xml#newcode13662 tools/metrics/histograms/histograms.xml:13662: + time when the API object is returned. See ...
4 years, 5 months ago (2016-06-29 19:44:14 UTC) #4
Devlin
https://codereview.chromium.org/2102383002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2102383002/diff/1/tools/metrics/histograms/histograms.xml#newcode13662 tools/metrics/histograms/histograms.xml:13662: + time when the API object is returned. See ...
4 years, 5 months ago (2016-06-29 19:50:18 UTC) #5
Mark P
histograms.xml lgtm
4 years, 5 months ago (2016-06-29 19:55:27 UTC) #6
lazyboy
lgtm
4 years, 5 months ago (2016-06-29 20:09:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102383002/20001
4 years, 5 months ago (2016-06-29 20:24:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 22:41:06 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 22:41:35 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:44:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95cbe926faeb42e0f4fcfa3c42c9cba95e77e4e5
Cr-Commit-Position: refs/heads/master@{#402969}

Powered by Google App Engine
This is Rietveld 408576698