🎑 Make android lint warnings show closer-to-correct file paths

Make android lint warnings show closer-to-correct file paths

Many of the paths are within /tmp. To address those, this change adds
relevant parent directories or path to originating .zip file in order
to provide context.

BUG=621769
Committed: https://crrev.com/3f9e0b4e45f6ae6a8822fa46f87b80c36f8c6339
Cr-Commit-Position: refs/heads/master@{#402802}

[agrieve, 2016-06-29 00:48:22]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 00:50:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 01:57:53]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-06-29 02:32:59]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 02:33:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-06-29 02:34:19]

Description was changed from

==========
Make android lint warnings show closer-to-correct file paths

Many of the paths are within /tmp. To address those, this change adds
relevant parent directories or path to originating .zip file in order
to provide context.

BUG=621769
==========

to

==========
Make android lint warnings show closer-to-correct file paths

Many of the paths are within /tmp. To address those, this change adds
relevant parent directories or path to originating .zip file in order
to provide context.

BUG=621769
==========

[agrieve, 2016-06-29 02:34:20]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-06-29 02:34:26]

On 2016/06/29 02:33:52, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 03:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 03:40:33]

Dry run: This issue passed the CQ dry run.

[jbudorick, 2016-06-29 08:45:17]

https://codereview.chromium.org/2102373002/diff/20001/build/android/gyp/lint.py
File build/android/gyp/lint.py (right):

https://codereview.chromium.org/2102373002/diff/20001/build/android/gyp/lint....
build/android/gyp/lint.py:98: def _NewTempSubdir(prefix, append_digit=True):
Why do we need this function at all? Why can't we tweak build_utils.TempDir to
expose some of the optional kwargs to tempfile.mkdtemp?

[agrieve, 2016-06-29 13:03:49]

https://codereview.chromium.org/2102373002/diff/20001/build/android/gyp/lint.py
File build/android/gyp/lint.py (right):

https://codereview.chromium.org/2102373002/diff/20001/build/android/gyp/lint....
build/android/gyp/lint.py:98: def _NewTempSubdir(prefix, append_digit=True):
On 2016/06/29 08:45:17, jbudorick (EMEA til June 30) wrote:
> Why do we need this function at all? Why can't we tweak build_utils.TempDir to
> expose some of the optional kwargs to tempfile.mkdtemp?

Before this change, it was just a convenient way of putting all temp directories
under a single temp directory.

With this change, it now creates nested subdirectories (prefix contains /'s) so
that even though the files are under /tmp, their immediate ancestors form a
meaningful description of where the files came from (either a .zip file or a
.java file in the tree)

[jbudorick, 2016-06-29 13:37:47]

lgtm

https://codereview.chromium.org/2102373002/diff/20001/build/android/gyp/lint.py
File build/android/gyp/lint.py (right):

https://codereview.chromium.org/2102373002/diff/20001/build/android/gyp/lint....
build/android/gyp/lint.py:98: def _NewTempSubdir(prefix, append_digit=True):
On 2016/06/29 13:03:49, agrieve wrote:
> On 2016/06/29 08:45:17, jbudorick (EMEA til June 30) wrote:
> > Why do we need this function at all? Why can't we tweak build_utils.TempDir
to
> > expose some of the optional kwargs to tempfile.mkdtemp?
> 
> Before this change, it was just a convenient way of putting all temp
directories
> under a single temp directory.
> 
> With this change, it now creates nested subdirectories (prefix contains /'s)
so
> that even though the files are under /tmp, their immediate ancestors form a
> meaningful description of where the files came from (either a .zip file or a
> .java file in the tree)

vvv

https://codereview.chromium.org/2102373002/diff/20001/build/android/gyp/lint....
build/android/gyp/lint.py:115: resource_dir =
_NewTempSubdir(_RebasePath(resource_source),
ah, I see what you mean.

[agrieve, 2016-06-29 14:27:48]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-06-29 14:28:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 14:32:53]

Description was changed from

==========
Make android lint warnings show closer-to-correct file paths

Many of the paths are within /tmp. To address those, this change adds
relevant parent directories or path to originating .zip file in order
to provide context.

BUG=621769
==========

to

==========
Make android lint warnings show closer-to-correct file paths

Many of the paths are within /tmp. To address those, this change adds
relevant parent directories or path to originating .zip file in order
to provide context.

BUG=621769
==========

[commit-bot: I haz the power, 2016-06-29 14:32:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 14:33:03]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 14:34:57]

Description was changed from

==========
Make android lint warnings show closer-to-correct file paths

Many of the paths are within /tmp. To address those, this change adds
relevant parent directories or path to originating .zip file in order
to provide context.

BUG=621769
==========

to

==========
Make android lint warnings show closer-to-correct file paths

Many of the paths are within /tmp. To address those, this change adds
relevant parent directories or path to originating .zip file in order
to provide context.

BUG=621769

Committed: https://crrev.com/3f9e0b4e45f6ae6a8822fa46f87b80c36f8c6339
Cr-Commit-Position: refs/heads/master@{#402802}
==========

[commit-bot: I haz the power, 2016-06-29 14:35:00]

Patchset 2 (id:??) landed as
https://crrev.com/3f9e0b4e45f6ae6a8822fa46f87b80c36f8c6339
Cr-Commit-Position: refs/heads/master@{#402802}