Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: base/BUILD.gn

Issue 2102363002: Revert of Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 1733 matching lines...) Expand 10 before | Expand all | Expand 10 after
1744 "cpu_unittest.cc", 1744 "cpu_unittest.cc",
1745 "debug/crash_logging_unittest.cc", 1745 "debug/crash_logging_unittest.cc",
1746 "debug/debugger_unittest.cc", 1746 "debug/debugger_unittest.cc",
1747 "debug/leak_tracker_unittest.cc", 1747 "debug/leak_tracker_unittest.cc",
1748 "debug/proc_maps_linux_unittest.cc", 1748 "debug/proc_maps_linux_unittest.cc",
1749 "debug/stack_trace_unittest.cc", 1749 "debug/stack_trace_unittest.cc",
1750 "debug/task_annotator_unittest.cc", 1750 "debug/task_annotator_unittest.cc",
1751 "deferred_sequenced_task_runner_unittest.cc", 1751 "deferred_sequenced_task_runner_unittest.cc",
1752 "environment_unittest.cc", 1752 "environment_unittest.cc",
1753 "feature_list_unittest.cc", 1753 "feature_list_unittest.cc",
1754 "file_version_info_win_unittest.cc", 1754 "file_version_info_unittest.cc",
1755 "files/dir_reader_posix_unittest.cc", 1755 "files/dir_reader_posix_unittest.cc",
1756 "files/file_locking_unittest.cc", 1756 "files/file_locking_unittest.cc",
1757 "files/file_path_unittest.cc", 1757 "files/file_path_unittest.cc",
1758 "files/file_path_watcher_unittest.cc", 1758 "files/file_path_watcher_unittest.cc",
1759 "files/file_proxy_unittest.cc", 1759 "files/file_proxy_unittest.cc",
1760 "files/file_unittest.cc", 1760 "files/file_unittest.cc",
1761 "files/file_util_proxy_unittest.cc", 1761 "files/file_util_proxy_unittest.cc",
1762 "files/file_util_unittest.cc", 1762 "files/file_util_unittest.cc",
1763 "files/important_file_writer_unittest.cc", 1763 "files/important_file_writer_unittest.cc",
1764 "files/memory_mapped_file_unittest.cc", 1764 "files/memory_mapped_file_unittest.cc",
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
2050 } 2050 }
2051 2051
2052 if (is_mac) { 2052 if (is_mac) {
2053 libs = [ 2053 libs = [
2054 "CoreFoundation.framework", 2054 "CoreFoundation.framework",
2055 "Foundation.framework", 2055 "Foundation.framework",
2056 ] 2056 ]
2057 } 2057 }
2058 2058
2059 if (is_linux) { 2059 if (is_linux) {
2060 sources -= [ "file_version_info_unittest.cc" ]
2061
2060 if (is_desktop_linux) { 2062 if (is_desktop_linux) {
2061 sources += [ "nix/xdg_util_unittest.cc" ] 2063 sources += [ "nix/xdg_util_unittest.cc" ]
2062 } 2064 }
2063 2065
2064 deps += [ "//base/test:malloc_wrapper" ] 2066 deps += [ "//base/test:malloc_wrapper" ]
2065 2067
2066 if (use_glib) { 2068 if (use_glib) {
2067 configs += [ "//build/config/linux:glib" ] 2069 configs += [ "//build/config/linux:glib" ]
2068 } 2070 }
2069 2071
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
2419 2421
2420 # GYP: //base.gyp:base_java_unittest_support 2422 # GYP: //base.gyp:base_java_unittest_support
2421 android_library("base_java_unittest_support") { 2423 android_library("base_java_unittest_support") {
2422 deps = [ 2424 deps = [
2423 ":base_java", 2425 ":base_java",
2424 ] 2426 ]
2425 java_files = 2427 java_files =
2426 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ] 2428 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
2427 } 2429 }
2428 } 2430 }
OLDNEW
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698