Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2102353002: Update browser manifest to require ProcessControl from gpu service (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update browser manifest to require ProcessControl from gpu service This adds a 'required' entry to the exe:content_browser manifest for content::mojom::ProcessControl in exe:content_gpu, allowing the browser to connect to the ProcessControl interface in the GPU process. Also fixes a bug in InterfaceRegistry which was causing useful log errors to be omitted when capability filters would block interface connection and registration. BUG=624112 TBR=ben@chromium.org Committed: https://crrev.com/6e5a7d11be2186aa51d20c4ab2ba51e2690fa27d Cr-Commit-Position: refs/heads/master@{#402665}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
M services/shell/public/cpp/lib/interface_registry.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102353002/20001
4 years, 5 months ago (2016-06-29 00:11:12 UTC) #3
Ben Goodger (Google)
lgtm !
4 years, 5 months ago (2016-06-29 00:42:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-06-29 02:20:09 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 02:21:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e5a7d11be2186aa51d20c4ab2ba51e2690fa27d
Cr-Commit-Position: refs/heads/master@{#402665}

Powered by Google App Engine
This is Rietveld 408576698