Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2102343002: [MD settings] allow horizontal scroll bar in settings content area (Closed)

Created:
4 years, 5 months ago by dschuyler
Modified:
4 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] allow horizontal scroll bar in settings content area This CL enables the automatic add/removal of the horizontal scroll bar at the bottom of the settings content area. BUG=623031 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bba010a71b42dd5199c5150ea9f4534bef03ade5 Cr-Commit-Position: refs/heads/master@{#402967}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review nit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (5 generated)
dschuyler
4 years, 5 months ago (2016-06-28 23:26:17 UTC) #3
tommycli
LGTM sans https://codereview.chromium.org/2102343002/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.html File chrome/browser/resources/settings/settings_ui/settings_ui.html (right): https://codereview.chromium.org/2102343002/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.html#newcode23 chrome/browser/resources/settings/settings_ui/settings_ui.html:23: overflow-x: auto; Since not immediately obvious, I ...
4 years, 5 months ago (2016-06-28 23:29:27 UTC) #4
dschuyler
https://codereview.chromium.org/2102343002/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.html File chrome/browser/resources/settings/settings_ui/settings_ui.html (right): https://codereview.chromium.org/2102343002/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.html#newcode23 chrome/browser/resources/settings/settings_ui/settings_ui.html:23: overflow-x: auto; On 2016/06/28 23:29:27, tommycli wrote: > Since ...
4 years, 5 months ago (2016-06-28 23:34:31 UTC) #5
tommycli
https://codereview.chromium.org/2102343002/diff/20001/chrome/browser/resources/settings/settings_ui/settings_ui.html File chrome/browser/resources/settings/settings_ui/settings_ui.html (right): https://codereview.chromium.org/2102343002/diff/20001/chrome/browser/resources/settings/settings_ui/settings_ui.html#newcode23 chrome/browser/resources/settings/settings_ui/settings_ui.html:23: overflow-x: auto; /* Undo paper-header-panel default of 'hidden'. */ ...
4 years, 5 months ago (2016-06-28 23:36:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102343002/20001
4 years, 5 months ago (2016-06-29 22:23:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 22:39:36 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 22:40:22 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:42:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bba010a71b42dd5199c5150ea9f4534bef03ade5
Cr-Commit-Position: refs/heads/master@{#402967}

Powered by Google App Engine
This is Rietveld 408576698