Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2102313002:
Roll buildtools 56eaae1346..c36df184fb (Closed)
|
Created:
4 years, 5 months ago by brettw Modified:
4 years, 5 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, Dirk Pranke, tfarina Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll buildtools 56eaae1346..c36df184fb
In order to roll GN 520de0f3c9..cadaad4370 (r400967:r402556) and pick up
the following changes:
c0ff886 Add GN split_list function.
db530b1 Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ )
74af4d6 Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ )
9f1375e Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python.
01c8157 Remove calls to deprecated MessageLoop methods in tools.
d6fd033c [Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents.
120e860 Add documentation about no sources for GN guide.
TBR=dpranke@chromium.org
Committed: https://crrev.com/4623d0c98a86a0fffb6de5c7e71b56bb13daf9bc
Cr-Commit-Position: refs/heads/master@{#402644}
Patch Set 1 #Patch Set 2 : Revert the thing #Messages
Total messages: 20 (10 generated)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by brettw@chromium.org
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll buildtools 56eaae1346..c36df184fb In order to roll GN 520de0f3c9..cadaad4370 (r400967:r402556) and pick up the following changes: c0ff886 Add GN split_list function. db530b1 Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ ) 74af4d6 Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ ) 9f1375e Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. 01c8157 Remove calls to deprecated MessageLoop methods in tools. d6fd033c [Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents. 120e860 Add documentation about no sources for GN guide. TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg ========== to ========== Roll buildtools 56eaae1346..c36df184fb In order to roll GN 520de0f3c9..cadaad4370 (r400967:r402556) and pick up the following changes: c0ff886 Add GN split_list function. db530b1 Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ ) 74af4d6 Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ ) 9f1375e Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. 01c8157 Remove calls to deprecated MessageLoop methods in tools. d6fd033c [Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents. 120e860 Add documentation about no sources for GN guide. TBR=dpranke@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_dbg on tryserver.chromium.mac (JOB_FAILED, no build URL) win8_chromium_gn_dbg on tryserver.chromium.win (JOB_FAILED, no build URL)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm assuming the bots all green up.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools 56eaae1346..c36df184fb In order to roll GN 520de0f3c9..cadaad4370 (r400967:r402556) and pick up the following changes: c0ff886 Add GN split_list function. db530b1 Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ ) 74af4d6 Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ ) 9f1375e Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. 01c8157 Remove calls to deprecated MessageLoop methods in tools. d6fd033c [Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents. 120e860 Add documentation about no sources for GN guide. TBR=dpranke@chromium.org ========== to ========== Roll buildtools 56eaae1346..c36df184fb In order to roll GN 520de0f3c9..cadaad4370 (r400967:r402556) and pick up the following changes: c0ff886 Add GN split_list function. db530b1 Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ ) 74af4d6 Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ ) 9f1375e Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. 01c8157 Remove calls to deprecated MessageLoop methods in tools. d6fd033c [Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents. 120e860 Add documentation about no sources for GN guide. TBR=dpranke@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools 56eaae1346..c36df184fb In order to roll GN 520de0f3c9..cadaad4370 (r400967:r402556) and pick up the following changes: c0ff886 Add GN split_list function. db530b1 Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ ) 74af4d6 Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ ) 9f1375e Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. 01c8157 Remove calls to deprecated MessageLoop methods in tools. d6fd033c [Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents. 120e860 Add documentation about no sources for GN guide. TBR=dpranke@chromium.org ========== to ========== Roll buildtools 56eaae1346..c36df184fb In order to roll GN 520de0f3c9..cadaad4370 (r400967:r402556) and pick up the following changes: c0ff886 Add GN split_list function. db530b1 Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ ) 74af4d6 Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ ) 9f1375e Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. 01c8157 Remove calls to deprecated MessageLoop methods in tools. d6fd033c [Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents. 120e860 Add documentation about no sources for GN guide. TBR=dpranke@chromium.org Committed: https://crrev.com/4623d0c98a86a0fffb6de5c7e71b56bb13daf9bc Cr-Commit-Position: refs/heads/master@{#402644} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4623d0c98a86a0fffb6de5c7e71b56bb13daf9bc Cr-Commit-Position: refs/heads/master@{#402644} |
