Gesture Nav: Protect against the case when navigation completes as soon as it is requested.

Gesture Nav: Protect against the case when navigation completes as soon as it is requested.

If DidStopLoading is called on WebContentsObserver immeditely after navigation
is requested, then window_ in could be released via StopObservingIfDone as soon
as GoForward/GoBack is called

OerscrollNavigationOverlay::OnOverscrollCompleted requests navigaions by calling
GoForward/GoBack on the controller. If these navigations immeditely trigger
DidStopLoading, main_window->SetTransform would segfault.
Protect against this case by setting up the transforms and window positioning
before doing navigation.

BUG=623620
Committed: https://crrev.com/85202fc5979f23d5db90b00b19db4cb7402cc8bf
Cr-Commit-Position: refs/heads/master@{#403186}

[mfomitchev, 2016-06-28 20:59:32]

Description was changed from

==========
Gesture Nav: Protect against the case when navigation completes as soon as it is
requested.

If DidStopLoading is called on WebContentsObserver immeditely after navigation
is requested, then window_ in could be released via StopObservingIfDone as soon
as GoForward/GoBack is called

OerscrollNavigationOverlay::OnOverscrollCompleted requests navigaions by calling
GoForward/GoBack on the controller. If these navigations immeditely trigger
DidStopLoading, main_window->SetTransform would segfault.
Protect against this case by setting up the transforms and window positioning
before doing navigation.

BUG=623620
==========

to

==========
Gesture Nav: Protect against the case when navigation completes as soon as it is
requested.

If DidStopLoading is called on WebContentsObserver immeditely after navigation
is requested, then window_ in could be released via StopObservingIfDone as soon
as GoForward/GoBack is called

OerscrollNavigationOverlay::OnOverscrollCompleted requests navigaions by calling
GoForward/GoBack on the controller. If these navigations immeditely trigger
DidStopLoading, main_window->SetTransform would segfault.
Protect against this case by setting up the transforms and window positioning
before doing navigation.

BUG=623620
==========

[mfomitchev, 2016-06-28 20:59:32]

mfomitchev@chromium.org changed reviewers:
+ creis@chromium.org, sadrul@chromium.org

[mfomitchev, 2016-06-28 20:59:59]

mfomitchev@chromium.org changed reviewers:
- creis@chromium.org

[mfomitchev, 2016-06-28 21:00:23]

sadrul: can you PTAL?

[sadrul, 2016-06-30 14:45:08]

lgtm

[mfomitchev, 2016-06-30 15:00:45]

The CQ bit was checked by mfomitchev@chromium.org

[commit-bot: I haz the power, 2016-06-30 15:01:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 15:54:38]

Description was changed from

==========
Gesture Nav: Protect against the case when navigation completes as soon as it is
requested.

If DidStopLoading is called on WebContentsObserver immeditely after navigation
is requested, then window_ in could be released via StopObservingIfDone as soon
as GoForward/GoBack is called

OerscrollNavigationOverlay::OnOverscrollCompleted requests navigaions by calling
GoForward/GoBack on the controller. If these navigations immeditely trigger
DidStopLoading, main_window->SetTransform would segfault.
Protect against this case by setting up the transforms and window positioning
before doing navigation.

BUG=623620
==========

to

==========
Gesture Nav: Protect against the case when navigation completes as soon as it is
requested.

If DidStopLoading is called on WebContentsObserver immeditely after navigation
is requested, then window_ in could be released via StopObservingIfDone as soon
as GoForward/GoBack is called

OerscrollNavigationOverlay::OnOverscrollCompleted requests navigaions by calling
GoForward/GoBack on the controller. If these navigations immeditely trigger
DidStopLoading, main_window->SetTransform would segfault.
Protect against this case by setting up the transforms and window positioning
before doing navigation.

BUG=623620
==========

[commit-bot: I haz the power, 2016-06-30 15:54:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-30 15:54:47]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 15:56:09]

Description was changed from

==========
Gesture Nav: Protect against the case when navigation completes as soon as it is
requested.

If DidStopLoading is called on WebContentsObserver immeditely after navigation
is requested, then window_ in could be released via StopObservingIfDone as soon
as GoForward/GoBack is called

OerscrollNavigationOverlay::OnOverscrollCompleted requests navigaions by calling
GoForward/GoBack on the controller. If these navigations immeditely trigger
DidStopLoading, main_window->SetTransform would segfault.
Protect against this case by setting up the transforms and window positioning
before doing navigation.

BUG=623620
==========

to

==========
Gesture Nav: Protect against the case when navigation completes as soon as it is
requested.

If DidStopLoading is called on WebContentsObserver immeditely after navigation
is requested, then window_ in could be released via StopObservingIfDone as soon
as GoForward/GoBack is called

OerscrollNavigationOverlay::OnOverscrollCompleted requests navigaions by calling
GoForward/GoBack on the controller. If these navigations immeditely trigger
DidStopLoading, main_window->SetTransform would segfault.
Protect against this case by setting up the transforms and window positioning
before doing navigation.

BUG=623620

Committed: https://crrev.com/85202fc5979f23d5db90b00b19db4cb7402cc8bf
Cr-Commit-Position: refs/heads/master@{#403186}
==========

[commit-bot: I haz the power, 2016-06-30 15:56:10]

Patchset 1 (id:??) landed as
https://crrev.com/85202fc5979f23d5db90b00b19db4cb7402cc8bf
Cr-Commit-Position: refs/heads/master@{#403186}