Issue 2102263002: Add Desktop Engagement Service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2102263002: Add Desktop Engagement Service (Closed)

Created:
4 years, 5 months ago by Patrick Monette

Modified:
4 years, 4 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add Desktop Engagement Service BUG=

Patch Set 1 #

Patch Set 2 : V2 #

Total comments: 2

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -0 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
A	chrome/browser/metrics/desktop_engagement_service.h	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
A	chrome/browser/metrics/desktop_engagement_service.cc	View	1	1 chunk	+83 lines, -0 lines	2 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Alexei Svitkine (slow)

4 years, 5 months ago (2016-06-29 18:27:22 UTC) #2

https://codereview.chromium.org/2102263002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/desktop_engagement_service.cc (right):

https://codereview.chromium.org/2102263002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/desktop_engagement_service.cc:24:
base::Unretained(this)));
Use a WeakPointerFactory member and pass a weak pointer instead of
base::Unretained()

https://codereview.chromium.org/2102263002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/desktop_engagement_service.cc:80:
UMA_HISTOGRAM_CUSTOM_TIMES("Session.TotalDuration.Desktop", delta,
Add to histograms.xml please. :)

Or just use Session.TotalDuration for the name, which I think we have for mobile
already?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages