Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: net/quic/quic_client_promised_info.cc

Issue 2102253003: Make SpdyHeaderBlock non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS fix. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_chromium_client_stream_test.cc ('k') | net/quic/quic_client_promised_info_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_promised_info.cc
diff --git a/net/quic/quic_client_promised_info.cc b/net/quic/quic_client_promised_info.cc
index 14cba80ee14e6659bf6a923899886a1b3fe59004..4de7adf83f3239691e5a9eb698b80fd3f4ad47da 100644
--- a/net/quic/quic_client_promised_info.cc
+++ b/net/quic/quic_client_promised_info.cc
@@ -56,11 +56,11 @@ void QuicClientPromisedInfo::OnPromiseHeaders(const SpdyHeaderBlock& headers) {
Reset(QUIC_UNAUTHORIZED_PROMISE_URL);
return;
}
- request_headers_.reset(new SpdyHeaderBlock(headers));
+ request_headers_.reset(new SpdyHeaderBlock(headers.Clone()));
}
void QuicClientPromisedInfo::OnResponseHeaders(const SpdyHeaderBlock& headers) {
- response_headers_.reset(new SpdyHeaderBlock(headers));
+ response_headers_.reset(new SpdyHeaderBlock(headers.Clone()));
if (client_request_delegate_) {
// We already have a client request waiting.
FinalValidation();
@@ -107,7 +107,7 @@ QuicAsyncStatus QuicClientPromisedInfo::HandleClientRequest(
return QUIC_FAILURE;
}
client_request_delegate_ = delegate;
- client_request_headers_.reset(new SpdyHeaderBlock(request_headers));
+ client_request_headers_.reset(new SpdyHeaderBlock(request_headers.Clone()));
if (!response_headers_) {
return QUIC_PENDING;
}
« no previous file with comments | « net/quic/quic_chromium_client_stream_test.cc ('k') | net/quic/quic_client_promised_info_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698