src/builtins.cc - Issue 2102203002: [builtins] Fix LoadObjectField for JSTypedArray::kBufferOffset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 2102203002: [builtins] Fix LoadObjectField for JSTypedArray::kBufferOffset (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index def3620b2ed2e0cbd4debd48bf14313cd9620ceb..c7749113e576e450789c81a688709606499c1ace 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -3222,7 +3222,7 @@ void Generate_TypedArrayProtoypeGetter(CodeStubAssembler* assembler,

Node* receiver_buffer =

assembler->LoadObjectField(receiver, JSTypedArray::kBufferOffset);

Node* receiver_buffer_bit_field = assembler->LoadObjectField(

- receiver_buffer, JSArrayBuffer::kBitFieldOffset, MachineType::Int8());

+ receiver_buffer, JSArrayBuffer::kBitFieldOffset, MachineType::Uint32());

Label if_receiverisneutered(assembler, Label::kDeferred);

assembler->GotoUnless(

assembler->Word32Equal(

« no previous file with comments | « no previous file | no next file » | no next file with comments »