Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 2102203002: [builtins] Fix LoadObjectField for JSTypedArray::kBufferOffset (Closed)

Created:
4 years, 5 months ago by john.yan
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fix LoadObjectField for JSTypedArray::kBufferOffset JSTypedArray::kBufferOffset contains a 32-bit integer in memory. And it's stored as whole at set_bit_field. When we try to load its first byte in memory, we get the less significant byte on LE but the most significant byte on BE, which is not consistent. R=bmeurer@chromium.org, gsathya@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/9995159a9f709df7302ad211a5710290e7621c54 Cr-Commit-Position: refs/heads/master@{#37396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 5 months ago (2016-06-28 18:57:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102203002/1
4 years, 5 months ago (2016-06-28 18:58:11 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 19:21:12 UTC) #5
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-06-29 03:50:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102203002/1
4 years, 5 months ago (2016-06-29 13:12:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 13:13:51 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 13:15:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9995159a9f709df7302ad211a5710290e7621c54
Cr-Commit-Position: refs/heads/master@{#37396}

Powered by Google App Engine
This is Rietveld 408576698