 Chromium Code Reviews
 Chromium Code Reviews Issue 21022018:
  Sessions API - previously Session Restore API. Supports restoring currently open foreign windows an…  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 21022018:
  Sessions API - previously Session Restore API. Supports restoring currently open foreign windows an…  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/common/extensions/api/windows.json | 
| diff --git a/chrome/common/extensions/api/windows.json b/chrome/common/extensions/api/windows.json | 
| index 7e3d2d6ebdc0f44659a8f227d043f4dad16b2463..d745bdb5fa58fbd3dc6e4506fdde7c622737f325 100644 | 
| --- a/chrome/common/extensions/api/windows.json | 
| +++ b/chrome/common/extensions/api/windows.json | 
| @@ -14,27 +14,28 @@ | 
| "id": "Window", | 
| "type": "object", | 
| "properties": { | 
| - "id": {"type": "integer", "optional": true, "minimum": 0, "description": "The ID of the window. Window IDs are unique within a browser session. Under some circumstances a Window may not be assigned an ID, for example when querying closed windows from the $ref:sessionRestore API."}, | 
| + "id": {"type": "integer", "optional": true, "minimum": 0, "description": "The ID of the window. Window IDs are unique within a browser session. Under some circumstances a Window may not be assigned an ID, for example when querying windows from the $ref:sessions API, in which case sessionId may be present."}, | 
| 
dharcourt
2013/08/16 02:27:34
Nit: "when querying windows from" -> "when queryin
 
Kristen Dwan
2013/08/16 22:03:06
Done.
 | 
| "focused": {"type": "boolean", "description": "Whether the window is currently the focused window."}, | 
| - "top": {"type": "integer", "optional": true, "description": "The offset of the window from the top edge of the screen in pixels. Under some circumstances a Window may not be assigned top property, for example when querying closed windows from the $ref:sessionRestore API."}, | 
| - "left": {"type": "integer", "optional": true, "description": "The offset of the window from the left edge of the screen in pixels. Under some circumstances a Window may not be assigned left property, for example when querying closed windows from the $ref:sessionRestore API."}, | 
| - "width": {"type": "integer", "optional": true, "description": "The width of the window, including the frame, in pixels. Under some circumstances a Window may not be assigned width property, for example when querying closed windows from the $ref:sessionRestore API."}, | 
| - "height": {"type": "integer", "optional": true, "description": "The height of the window, including the frame, in pixels. Under some circumstances a Window may not be assigned height property, for example when querying closed windows from the $ref:sessionRestore API."}, | 
| + "top": {"type": "integer", "optional": true, "description": "The offset of the window from the top edge of the screen in pixels. Under some circumstances a Window may not be assigned top property, for example when querying closed windows from the $ref:sessions API."}, | 
| + "left": {"type": "integer", "optional": true, "description": "The offset of the window from the left edge of the screen in pixels. Under some circumstances a Window may not be assigned left property, for example when querying closed windows from the $ref:sessions API."}, | 
| + "width": {"type": "integer", "optional": true, "description": "The width of the window, including the frame, in pixels. Under some circumstances a Window may not be assigned width property, for example when querying closed windows from the $ref:sessions API."}, | 
| + "height": {"type": "integer", "optional": true, "description": "The height of the window, including the frame, in pixels. Under some circumstances a Window may not be assigned height property, for example when querying closed windows from the $ref:sessions API."}, | 
| "tabs": {"type": "array", "items": { "$ref": "tabs.Tab" }, "optional": true, "description": "Array of $ref:tabs.Tab objects representing the current tabs in the window."}, | 
| "incognito": {"type": "boolean", "description": "Whether the window is incognito."}, | 
| "type": { | 
| "type": "string", | 
| "optional": true, | 
| - "description": "The type of browser window this is. Under some circumstances a Window may not be assigned type property, for example when querying closed windows from the $ref:sessionRestore API.", | 
| + "description": "The type of browser window this is. Under some circumstances a Window may not be assigned type property, for example when querying closed windows from the $ref:sessions API.", | 
| "enum": ["normal", "popup", "panel", "app"] | 
| }, | 
| "state": { | 
| "type": "string", | 
| "optional": true, | 
| - "description": "The state of this browser window. Under some circumstances a Window may not be assigned state property, for example when querying closed windows from the $ref:sessionRestore API.", | 
| + "description": "The state of this browser window. Under some circumstances a Window may not be assigned state property, for example when querying closed windows from the $ref:sessions API.", | 
| "enum": ["normal", "minimized", "maximized", "fullscreen"] | 
| }, | 
| - "alwaysOnTop": {"type": "boolean", "description": "Whether the window is set to be always on top."} | 
| + "alwaysOnTop": {"type": "boolean", "description": "Whether the window is set to be always on top."}, | 
| + "sessionId": {"type": "string", "optional": true, "description": "The session ID used to uniquely identify a Window from the $ref:sessions API."} | 
| 
dharcourt
2013/08/16 02:27:34
Nit: "a Window from" -> "a Window obtained from".
 
Kristen Dwan
2013/08/16 22:03:06
Done.
 | 
| } | 
| } | 
| ], |