Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 21022014: Move id attribute to parent Element interface (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, f(malita), adamk+blink_chromium.org, pdr, Stephen Chennney, lgombos
Visibility:
Public.

Description

Move id attribute to parent Element interface Move id attribute from SVGElement / HTMLElement to their Element parent interface to match the latest DOM specification and avoid duplication: http://dom.spec.whatwg.org/#dom-element-id This behavior is consistent with Firefox. There is no web-exposed behavior change because we haven't moved properties from instances to their prototype, as per the Web IDL specification (http://dev.w3.org/2006/webapi/WebIDL/#es-attributes). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/core/dom/Element.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
do-not-use
7 years, 4 months ago (2013-07-31 12:08:46 UTC) #1
do-not-use
On 2013/07/31 12:08:46, Christophe Dumez wrote: Firefox already exposes 'id' on the Element prototype.
7 years, 4 months ago (2013-07-31 12:13:04 UTC) #2
haraken
Given that getIdAttribute() is already defined in Element.h, this change sounds reasonable. LGTM.
7 years, 4 months ago (2013-07-31 12:13:58 UTC) #3
do-not-use
On 2013/07/31 12:13:04, Christophe Dumez wrote: > On 2013/07/31 12:08:46, Christophe Dumez wrote: > > ...
7 years, 4 months ago (2013-07-31 12:15:56 UTC) #4
arv (Not doing code reviews)
LGTM On Jul 31, 2013 8:15 AM, <ch.dumez@sisa.samsung.com> wrote: > On 2013/07/31 12:13:04, Christophe Dumez ...
7 years, 4 months ago (2013-07-31 12:26:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21022014/1
7 years, 4 months ago (2013-07-31 12:28:02 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 14:16:19 UTC) #7
Message was sent while issue was closed.
Change committed as 155245

Powered by Google App Engine
This is Rietveld 408576698