Revert "Revert "[wasm] Complete separation of compilation and instantiation""

Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

The original compilation separation change avoided associating a heap
for the wasm instance if memory was not provided, nor needed. The
grow memory CL assumed the old behavior, where a memory buffer was
always present, but may have had a zero size.

The 2CLS  landed shortly after one another. We decided to treat the
grow memory as the race condition winner, so this CL here re-lands
compilation separation, plus adjusts grow memory to deal with
the undefined mem buffer.

BUG=

Committed: https://crrev.com/9d6014ad55bf37afb614e210ebfb329b00df7bb2
Cr-Commit-Position: refs/heads/master@{#37352}

[Mircea Trofin, 2016-06-28 22:48:18]

Description was changed from

==========
Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

BUG=
==========

to

==========
Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

The original change avoided associating a heap for the wasm instance
if memory was not provided, nor needed. The grow memory CL landed
assumed the old behavior. The 2 landed shortly after one another, and
the CQ didn't re-run for the second one to land.

This CL re-lands compilation separation, plus adjusts grow memory
to deal with undefined mem buffer.

BUG=
==========

[Mircea Trofin, 2016-06-28 22:48:19]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org, gdeepti@chromium.org

[Mircea Trofin, 2016-06-28 22:55:46]

Description was changed from

==========
Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

The original change avoided associating a heap for the wasm instance
if memory was not provided, nor needed. The grow memory CL landed
assumed the old behavior. The 2 landed shortly after one another, and
the CQ didn't re-run for the second one to land.

This CL re-lands compilation separation, plus adjusts grow memory
to deal with undefined mem buffer.

BUG=
==========

to

==========
Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

The original compilation separation change avoided associating a heap 
for the wasm instance if memory was not provided, nor needed. The 
grow memory CL assumed the old behavior, where a memory buffer was
always present, but may have had a zero size. 

The 2CLS  landed shortly after one another. We decided to treat the 
grow memory as the race condition winner, so this CL here re-lands compilation
separation, plus adjusts grow memory to deal with 
the undefined mem buffer.

BUG=
==========

[Mircea Trofin, 2016-06-28 22:56:27]

Description was changed from

==========
Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

The original compilation separation change avoided associating a heap 
for the wasm instance if memory was not provided, nor needed. The 
grow memory CL assumed the old behavior, where a memory buffer was
always present, but may have had a zero size. 

The 2CLS  landed shortly after one another. We decided to treat the 
grow memory as the race condition winner, so this CL here re-lands compilation
separation, plus adjusts grow memory to deal with 
the undefined mem buffer.

BUG=
==========

to

==========
Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

The original compilation separation change avoided associating a heap 
for the wasm instance if memory was not provided, nor needed. The 
grow memory CL assumed the old behavior, where a memory buffer was
always present, but may have had a zero size. 

The 2CLS  landed shortly after one another. We decided to treat the 
grow memory as the race condition winner, so this CL here re-lands 
compilation separation, plus adjusts grow memory to deal with 
the undefined mem buffer.

BUG=
==========

[gdeepti, 2016-06-28 23:35:05]

lgtm for grow_mem changes

[bradnelson, 2016-06-28 23:45:21]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-06-28 23:45:22]

lgtm

[commit-bot: I haz the power, 2016-06-28 23:45:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 23:47:40]

Description was changed from

==========
Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

The original compilation separation change avoided associating a heap 
for the wasm instance if memory was not provided, nor needed. The 
grow memory CL assumed the old behavior, where a memory buffer was
always present, but may have had a zero size. 

The 2CLS  landed shortly after one another. We decided to treat the 
grow memory as the race condition winner, so this CL here re-lands 
compilation separation, plus adjusts grow memory to deal with 
the undefined mem buffer.

BUG=
==========

to

==========
Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

The original compilation separation change avoided associating a heap 
for the wasm instance if memory was not provided, nor needed. The 
grow memory CL assumed the old behavior, where a memory buffer was
always present, but may have had a zero size. 

The 2CLS  landed shortly after one another. We decided to treat the 
grow memory as the race condition winner, so this CL here re-lands 
compilation separation, plus adjusts grow memory to deal with 
the undefined mem buffer.

BUG=
==========

[commit-bot: I haz the power, 2016-06-28 23:47:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-28 23:50:25]

Description was changed from

==========
Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

The original compilation separation change avoided associating a heap 
for the wasm instance if memory was not provided, nor needed. The 
grow memory CL assumed the old behavior, where a memory buffer was
always present, but may have had a zero size. 

The 2CLS  landed shortly after one another. We decided to treat the 
grow memory as the race condition winner, so this CL here re-lands 
compilation separation, plus adjusts grow memory to deal with 
the undefined mem buffer.

BUG=
==========

to

==========
Revert "Revert "[wasm] Complete separation of compilation and instantiation""

This reverts commit 1eb1dfabe4bf8ff934047335dfebafb8f0dfc550.

The original compilation separation change avoided associating a heap
for the wasm instance if memory was not provided, nor needed. The
grow memory CL assumed the old behavior, where a memory buffer was
always present, but may have had a zero size.

The 2CLS  landed shortly after one another. We decided to treat the
grow memory as the race condition winner, so this CL here re-lands
compilation separation, plus adjusts grow memory to deal with
the undefined mem buffer.

BUG=

Committed: https://crrev.com/9d6014ad55bf37afb614e210ebfb329b00df7bb2
Cr-Commit-Position: refs/heads/master@{#37352}
==========

[commit-bot: I haz the power, 2016-06-28 23:50:26]

Patchset 3 (id:??) landed as
https://crrev.com/9d6014ad55bf37afb614e210ebfb329b00df7bb2
Cr-Commit-Position: refs/heads/master@{#37352}