Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2102173003: blimp: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj, nyquist, dcheng
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blimp: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=nyquist, danakj, dcheng BUG=554600 Committed: https://crrev.com/2f37e9e61a72d10f5c9be9d5021445eacec42ad0 Cr-Commit-Position: refs/heads/master@{#405228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M blimp/client/session/assignment_source_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/engine/app/blimp_url_request_context_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/renderer/engine_image_serialization_processor.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-28 21:34:56 UTC) #1
danakj
LGTM
4 years, 5 months ago (2016-06-28 22:10:06 UTC) #2
nyquist
lgtm
4 years, 5 months ago (2016-07-01 19:13:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102173003/1
4 years, 5 months ago (2016-07-13 18:48:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 19:42:27 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 19:43:21 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 19:44:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f37e9e61a72d10f5c9be9d5021445eacec42ad0
Cr-Commit-Position: refs/heads/master@{#405228}

Powered by Google App Engine
This is Rietveld 408576698