Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2102153003: GLFrameData: Remove dead code (Closed)

Created:
4 years, 5 months ago by Fady Samuel
Modified:
4 years, 5 months ago
Reviewers:
dcheng, piman
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GLFrameData: Remove dead code GLFrameData sync_token and mailbox are now dead code as is MailboxOutputSurface. BUG=none TBR=dcheng@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f7e676a7fa85e5910c241ab84f61fb2cf890b0e8 Cr-Commit-Position: refs/heads/master@{#402588}

Patch Set 1 #

Patch Set 2 : Fix content_browsertests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -364 lines) Patch
M cc/ipc/cc_param_traits_macros.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/gl_frame_data.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/layouttest_support.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D content/test/mailbox_output_surface.h View 1 chunk +0 lines, -84 lines 0 comments Download
D content/test/mailbox_output_surface.cc View 1 chunk +0 lines, -272 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Fady Samuel
+piman@ for review +dcheng@ for IPC review (just code removal so I'm TBR'ing you) +danakj ...
4 years, 5 months ago (2016-06-28 19:01:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102153003/1
4 years, 5 months ago (2016-06-28 19:03:19 UTC) #5
piman
lgtm
4 years, 5 months ago (2016-06-28 19:10:34 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/226209) mac_chromium_rel_ng on ...
4 years, 5 months ago (2016-06-28 19:21:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102153003/20001
4 years, 5 months ago (2016-06-28 19:34:10 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/184671) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-06-28 19:45:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102153003/20001
4 years, 5 months ago (2016-06-28 21:08:57 UTC) #16
dcheng
ipc lgtm
4 years, 5 months ago (2016-06-28 21:09:56 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 23:14:44 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 23:18:04 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7e676a7fa85e5910c241ab84f61fb2cf890b0e8
Cr-Commit-Position: refs/heads/master@{#402588}

Powered by Google App Engine
This is Rietveld 408576698