[WebViewShell] Add activity for opening urls while creating/destroying webviews.

[WebViewShell] Add activity for opening urls while creating/destroying webviews.

Add WebViewCreateDestroyActivity which makes sure to destroy any existing
instance of webview before opening a url in a new webview on each intent.
This is required for mutiple webview telemetry and memory benchmarking,
see crbug.com/619812.

BUG=619812
Committed: https://crrev.com/2ae952d08053dbe229f0a11df5fffc126db1c012
Cr-Commit-Position: refs/heads/master@{#404393}

[timvolodine, 2016-06-28 18:23:15]

timvolodine@chromium.org changed reviewers:
+ perezju@chromium.org, tsergeant@chromium.org

[timvolodine, 2016-06-28 18:23:16]

perezju@: to check if that's what we need for benchmark testing
tsergeant@: for the webview-side

[boliu, 2016-06-28 18:42:13]

On 2016/06/28 18:23:16, timvolodine wrote:
> perezju@: to check if that's what we need for benchmark testing
> tsergeant@: for the webview-side

err, tobiasjs..?

[boliu, 2016-06-28 18:46:12]

boliu@chromium.org changed reviewers:
+ boliu@chromium.org, tobiasjs@chromium.org
- tsergeant@chromium.org

[boliu, 2016-06-28 18:46:12]

+tobiasjs
-tsergeant

[boliu, 2016-06-28 18:46:22]

Description was changed from

==========
[WebViewShell] Add activity for opening urls while creating/destroying webviews.

Add WebViewCreateDestroyActivity which makes sure to destroy any existing
instance of webview before opening a url in a new webview on each intent.
This is required for mutiple webview telemetry and memory benchmarking,
see crbug.com/619812.

BUG=619812
==========

to

==========
[WebViewShell] Add activity for opening urls while creating/destroying webviews.

Add WebViewCreateDestroyActivity which makes sure to destroy any existing
instance of webview before opening a url in a new webview on each intent.
This is required for mutiple webview telemetry and memory benchmarking,
see crbug.com/619812.

BUG=619812
==========

[boliu, 2016-06-28 18:46:22]

boliu@chromium.org changed reviewers:
- boliu@chromium.org

[timvolodine, 2016-06-28 18:48:54]

On 2016/06/28 18:46:12, boliu wrote:
> +tobiasjs
> -tsergeant

oops, and also misspelled the name sorry.. thanks Bo!

[perezju, 2016-06-29 10:00:19]

lgtm

Just have a question: for this to work do we always need to use the
WebViewCreateDestroyActivity? Or can the activities be mixed? E.g. launching
with TelemetryActivity and then sending a WebViewCreateDestroyActivity; would
that also destroy the first WebView?

[timvolodine, 2016-06-29 14:22:31]

On 2016/06/29 10:00:19, perezju wrote:
> lgtm
> 
> Just have a question: for this to work do we always need to use the
> WebViewCreateDestroyActivity? Or can the activities be mixed? E.g. launching
> with TelemetryActivity and then sending a WebViewCreateDestroyActivity; would
> that also destroy the first WebView?

WebViewCreateDestroyActivity will not destroy the webview in Telemetry. In
particular if you launch TelemetryActivity first and then
WebViewCreateDestroyActivity you would end up with two webviews in total.

We can consider adding such functionality though if that is useful for
telemetry..

[perezju, 2016-06-29 14:40:51]

On 2016/06/29 14:22:31, timvolodine wrote:
> On 2016/06/29 10:00:19, perezju wrote:
> > lgtm
> > 
> > Just have a question: for this to work do we always need to use the
> > WebViewCreateDestroyActivity? Or can the activities be mixed? E.g. launching
> > with TelemetryActivity and then sending a WebViewCreateDestroyActivity;
would
> > that also destroy the first WebView?
> 
> WebViewCreateDestroyActivity will not destroy the webview in Telemetry. In
> particular if you launch TelemetryActivity first and then
> WebViewCreateDestroyActivity you would end up with two webviews in total.
> 
> We can consider adding such functionality though if that is useful for
> telemetry..

No need. I'm OK with this behavior. I would only ask to document this in the doc
string for WebViewCreateDestroyActivity.

[timvolodine, 2016-06-29 15:00:12]

On 2016/06/29 14:40:51, perezju wrote:
> On 2016/06/29 14:22:31, timvolodine wrote:
> > On 2016/06/29 10:00:19, perezju wrote:
> > > lgtm
> > > 
> > > Just have a question: for this to work do we always need to use the
> > > WebViewCreateDestroyActivity? Or can the activities be mixed? E.g.
launching
> > > with TelemetryActivity and then sending a WebViewCreateDestroyActivity;
> would
> > > that also destroy the first WebView?
> > 
> > WebViewCreateDestroyActivity will not destroy the webview in Telemetry. In
> > particular if you launch TelemetryActivity first and then
> > WebViewCreateDestroyActivity you would end up with two webviews in total.
> > 
> > We can consider adding such functionality though if that is useful for
> > telemetry..
> 
> No need. I'm OK with this behavior. I would only ask to document this in the
doc
> string for WebViewCreateDestroyActivity.

ok, done.

going forward we can make it more flexible if needed e.g. sending intents to
create or destroy webviews; that would depend on potential telemetry usage and
test cases though so let me know if you require something like that.

[Tobias Sargeant, 2016-06-29 17:37:58]

LGTM

[timvolodine, 2016-07-07 13:41:12]

On 2016/06/29 17:37:58, Tobias Sargeant wrote:
> LGTM

thanks for the reviews!

[timvolodine, 2016-07-07 13:41:18]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-07-07 13:41:19]

The patchset sent to the CQ was uploaded after l-g-t-m from perezju@chromium.org
Link to the patchset: https://codereview.chromium.org/2102153002/#ps40001
(title: "no-find-copies")

[commit-bot: I haz the power, 2016-07-07 13:41:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 16:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 16:24:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
no build URL)

[timvolodine, 2016-07-07 16:27:46]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2016-07-07 16:28:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 19:30:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 19:30:29]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[timvolodine, 2016-07-08 10:56:37]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2016-07-08 10:57:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 15:37:24]

Description was changed from

==========
[WebViewShell] Add activity for opening urls while creating/destroying webviews.

Add WebViewCreateDestroyActivity which makes sure to destroy any existing
instance of webview before opening a url in a new webview on each intent.
This is required for mutiple webview telemetry and memory benchmarking,
see crbug.com/619812.

BUG=619812
==========

to

==========
[WebViewShell] Add activity for opening urls while creating/destroying webviews.

Add WebViewCreateDestroyActivity which makes sure to destroy any existing
instance of webview before opening a url in a new webview on each intent.
This is required for mutiple webview telemetry and memory benchmarking,
see crbug.com/619812.

BUG=619812
==========

[commit-bot: I haz the power, 2016-07-08 15:37:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-08 15:37:34]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 15:39:19]

Description was changed from

==========
[WebViewShell] Add activity for opening urls while creating/destroying webviews.

Add WebViewCreateDestroyActivity which makes sure to destroy any existing
instance of webview before opening a url in a new webview on each intent.
This is required for mutiple webview telemetry and memory benchmarking,
see crbug.com/619812.

BUG=619812
==========

to

==========
[WebViewShell] Add activity for opening urls while creating/destroying webviews.

Add WebViewCreateDestroyActivity which makes sure to destroy any existing
instance of webview before opening a url in a new webview on each intent.
This is required for mutiple webview telemetry and memory benchmarking,
see crbug.com/619812.

BUG=619812

Committed: https://crrev.com/2ae952d08053dbe229f0a11df5fffc126db1c012
Cr-Commit-Position: refs/heads/master@{#404393}
==========

[commit-bot: I haz the power, 2016-07-08 15:39:20]

Patchset 3 (id:??) landed as
https://crrev.com/2ae952d08053dbe229f0a11df5fffc126db1c012
Cr-Commit-Position: refs/heads/master@{#404393}