Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

Issue 2102133002: Add constructors for WebAudio nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and prefix use counter names with WebAudio Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
index 211dfb09800b93f12823587a7c0fb0b660efeedb..729e4b0f89115c03dedd1d3745636e8df8ff0259 100644
--- a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
@@ -29,6 +29,7 @@
#include "core/inspector/ConsoleMessage.h"
#include "modules/webaudio/AudioNodeOutput.h"
#include "modules/webaudio/BaseAudioContext.h"
+#include "modules/webaudio/MediaElementAudioSourceOptions.h"
#include "platform/audio/AudioUtilities.h"
#include "platform/weborigin/SecurityOrigin.h"
#include "wtf/Locker.h"
@@ -235,6 +236,18 @@ MediaElementAudioSourceNode* MediaElementAudioSourceNode::create(BaseAudioContex
return node;
}
+MediaElementAudioSourceNode* MediaElementAudioSourceNode::create(BaseAudioContext* context, const MediaElementAudioSourceOptions& options, ExceptionState& exceptionState)
+{
+ if (!options.hasMediaElement()) {
+ exceptionState.throwDOMException(
+ NotFoundError,
+ "mediaElement member is required.");
+ return nullptr;
+ }
+
+ return create(*context, *options.mediaElement(), exceptionState);
+}
+
DEFINE_TRACE(MediaElementAudioSourceNode)
{
AudioSourceProviderClient::trace(visitor);

Powered by Google App Engine
This is Rietveld 408576698