Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

Issue 2102133002: Add constructors for WebAudio nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and prefix use counter names with WebAudio Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
index 417a55ec582f53f9c2b114332188f61c23ece06e..93e129d2e276d9353db52d1593b7ede6ab63e4f5 100644
--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
@@ -25,6 +25,7 @@
#include "modules/webaudio/AudioNodeInput.h"
#include "modules/webaudio/AudioNodeOutput.h"
#include "modules/webaudio/DynamicsCompressorNode.h"
+#include "modules/webaudio/DynamicsCompressorOptions.h"
#include "platform/audio/DynamicsCompressor.h"
#include "wtf/PtrUtil.h"
@@ -156,6 +157,29 @@ DynamicsCompressorNode* DynamicsCompressorNode::create(BaseAudioContext& context
return new DynamicsCompressorNode(context);
}
+DynamicsCompressorNode* DynamicsCompressorNode::create(BaseAudioContext* context, const DynamicsCompressorOptions& options, ExceptionState& exceptionState)
+{
+ DynamicsCompressorNode* node = create(*context, exceptionState);
+
+ if (!node)
+ return nullptr;
+
+ node->handleChannelOptions(options, exceptionState);
+
+ if (options.hasAttack())
+ node->attack()->setValue(options.attack());
+ if (options.hasKnee())
+ node->knee()->setValue(options.knee());
+ if (options.hasRatio())
+ node->ratio()->setValue(options.ratio());
+ if (options.hasRelease())
+ node->release()->setValue(options.release());
+ if (options.hasThreshold())
+ node->threshold()->setValue(options.threshold());
+
+ return node;
+}
+
DEFINE_TRACE(DynamicsCompressorNode)
{
visitor->trace(m_threshold);

Powered by Google App Engine
This is Rietveld 408576698