Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html

Issue 2102133002: Add constructors for WebAudio nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments, rebase, and JSON.stringify the things Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html ('k') | third_party/WebKit/LayoutTests/webaudio/constructor/delay.html » ('j') | third_party/WebKit/LayoutTests/webaudio/constructor/dynamicscompressor.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html b/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
new file mode 100644
index 0000000000000000000000000000000000000000..f810b657911b6f3617401fd495594bb771b48fa5
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
@@ -0,0 +1,132 @@
+<!doctype html>
+<html>
+ <head>
+ <title>Test Constructor: Convolver</title>
+ <script src="../../resources/testharness.js"></script>
+ <script src="../../resources/testharnessreport.js"></script>
+ <script src="../resources/audio-testing.js"></script>
+ <script src="audionodeoptions.js"></script>
+ </head>
+
+ <body>
+ <script>
+ var context;
+
+ var audit = Audit.createTaskRunner();
+
+ audit.defineTask("initialize", function (taskDone) {
+ Should("context = new OfflineAudioContext(...)", function () {
+ context = new OfflineAudioContext(1, 1, 48000);
+ }).notThrow();
+ taskDone();
+ });
+
+ audit.defineTask("invalid constructor", function (taskDone) {
+ var node;
+ var success = true;
+
+ succes = Should("new ConvolverNode()", function () {
+ node = new ConvolverNode();
+ }).throw("TypeError");
+ success = Should("new ConvolverNode(1)", function () {
+ node = new ConvolverNode(1);
+ }).throw("TypeError") && success;
+ success = Should("new ConvolverNode(context, 42)", function () {
+ node = new ConvolverNode(context, 42);
+ }).throw("TypeError") && success;
+
+ Should("Invalid constructors", success)
+ .summarize(
+ "correctly threw errors",
+ "did not throw errors in all cases");
+ taskDone();
+ });
+
+ audit.defineTask("default constructor", function (taskDone) {
+ var node;
+ var success = true;
+
+ success = Should("node = new ConvolverNode(context)", function () {
+ node = new ConvolverNode(context);
+ }).notThrow();
+ success = Should("node instanceOf ConvolverNode", node instanceof ConvolverNode)
+ .beEqualTo(true) && success;
+ success = Should("node.normalize", node.normalize)
+ .beEqualTo(true) && success;
+
+ success = Should("node.channelCount", node.channelCount)
+ .beEqualTo(2) && success;
+ success = Should("node.channelCountMode", node.channelCountMode)
+ .beEqualTo("clamped-max") && success;
+ success = Should("node.channelInterpretation", node.channelInterpretation)
+ .beEqualTo("speakers") && success;
+
+ success = Should("new AnalyserNode(context)", success)
+ .summarize(
+ "constructed node with correct attributes",
+ "did not construct correct node correctly")
+
+ taskDone();
+ });
+
+ audit.defineTask("test AudioNodeOptions", function (taskDone) {
+ testAudioNodeOptions(context, "ConvolverNode");
+ taskDone();
+ });
+
+ audit.defineTask("construct with options", function (taskDone) {
+ var buf = context.createBuffer(1, 1, context.sampleRate);
+ var options = {
+ buffer: buf,
+ disableNormalization: false
+ };
+
+ var message = "node = new ConvolverNode(c, " + JSON.stringify(options) + ")";
+
+ var node;
+ success = Should(message, function () {
+ node = new ConvolverNode(context, options);
+ }).notThrow();
+
+ success = Should("node instanceOf ConvolverNode", node instanceof ConvolverNode)
+ .beEqualTo(true) && success;
+ success = Should("node.buffer === <buf>", node.buffer ===
+ options.buffer)
+ .beEqualTo(true) && success;
+ success = Should("node.normalize", node.normalize)
+ .beEqualTo(!options.disableNormalization) && success;
+
+ options.buffer = null;
+ options.disableNormalization = true;
+
+ message = "node = new ConvolverNode(, " + JSON.stringify(options) + ")";
+
+ success = Should(message, function () {
+ node = new ConvolverNode(context, options);
+ }).notThrow() && success;
+ success = Should("node.buffer", node.buffer).beEqualTo(null) && success;
+ success = Should("node.normalize", node.normalize)
+ .beEqualTo(!options.disableNormalization) && success;
+
+ options.disableNormalization = false;
+ message = "node = new ConvolverNode(context, " + JSON.stringify(options) + "";
hongchan 2016/09/14 17:40:07 Perhaps this empty quote is a mistake?
Raymond Toy 2016/09/14 18:02:23 Fixed. It should be ")"
+
+ success = Should(message, function () {
+ node = new ConvolverNode(context, options);
+ }).notThrow() && success;
+ success = Should("node.buffer", node.buffer).beEqualTo(null) && success;
+ success = Should("node.normalize", node.normalize)
+ .beEqualTo(!options.disableNormalization) && success;
+
+ Should("new ConvolverNode() with options", success)
+ .summarize(
+ "constructed with correct attributes",
+ "was not constructed correctly");
+
+ taskDone();
+ });
+
+ audit.runTasks();
+ </script>
+ </body>
+</html>
« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html ('k') | third_party/WebKit/LayoutTests/webaudio/constructor/delay.html » ('j') | third_party/WebKit/LayoutTests/webaudio/constructor/dynamicscompressor.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698