third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h - Issue 2102133002: Add constructors for WebAudio nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

Issue 2102133002: Add constructors for WebAudio nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html ('K') | « third_party/WebKit/Source/modules/webaudio/DelayOptions.idl ('k') | third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

index 25c1ab3d37e7625a476ef58afe3ae6de3f6e5180..9a4cc990eec1cc0f2ea27040a3e82afacd06cfb9 100644

--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

@@ -35,6 +35,7 @@ namespace blink {

class BaseAudioContext;

class DynamicsCompressor;

+class DynamicsCompressorOptions;

class MODULES_EXPORT DynamicsCompressorHandler final : public AudioHandler {

public:

@@ -82,6 +83,7 @@ class MODULES_EXPORT DynamicsCompressorNode final : public AudioNode {

DEFINE_WRAPPERTYPEINFO();

public:

static DynamicsCompressorNode* create(BaseAudioContext&, ExceptionState&);

+ static DynamicsCompressorNode* create(BaseAudioContext*, const DynamicsCompressorOptions&, ExceptionState&);

DECLARE_VIRTUAL_TRACE();

AudioParam* threshold() const;