Chromium Code Reviews Chromium Code Reviews
Issue 2102133002:
Add constructors for WebAudio nodes (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/webaudio/constructor/gain.html |
| diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/gain.html b/third_party/WebKit/LayoutTests/webaudio/constructor/gain.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..13f109cca21089496b4971f7324f53cacf3f35bc |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/webaudio/constructor/gain.html |
| @@ -0,0 +1,115 @@ |
| +<!doctype html> |
| +<html> |
| + <head> |
| + <title>Test Constructor: Gain</title> |
| + <script src="../../resources/testharness.js"></script> |
| + <script src="../../resources/testharnessreport.js"></script> |
| + <script src="../resources/audio-testing.js"></script> |
| + <script src="audionodeoptions.js"></script> |
| + </head> |
| + |
| + <body> |
| + <script> |
| + var context; |
| + |
| + var audit = Audit.createTaskRunner(); |
| + |
| + audit.defineTask("initialize", function (taskDone) { |
| + Should("context = new OfflineAudioContext(...)", function () { |
| + context = new OfflineAudioContext(1, 1, 48000); |
| + }).notThrow(); |
| + taskDone(); |
| + }); |
| + |
| + audit.defineTask("invalid constructor", function (taskDone) { |
| + var node; |
| + var success = true; |
| + |
| + success = Should("new GainNode()", function () { |
| + node = new GainNode(); |
| + }).throw("TypeError"); |
| + success = Should("new GainNode(1)", function () { |
| + node = new GainNode(1); |
| + }).throw("TypeError") && success; |
| + success = Should("new GainNode(context, 42)", function () { |
| + node = new GainNode(context, 42); |
| + }).throw("TypeError") && success; |
| + |
| + Should("Invalid constructors", success) |
| + .summarize( |
| + "correctly threw errors", |
| + "did not throw errors in all cases"); |
| + |
| + taskDone(); |
| + }); |
| + |
| + audit.defineTask("default constructor", function (taskDone) { |
| + var node; |
| + var success = true; |
| + |
| + success = success = Should("node = new GainNode(context)", function () { |
|
hongchan
2016/09/13 22:13:22
Two |success| here as well.
Raymond Toy
2016/09/14 18:02:23
Fixed.
|
| + node = new GainNode(context); |
| + }).notThrow(); |
| + success = success = Should("node instanceof GainNode", |
| + node instanceof GainNode) |
| + .beEqualTo(true) && success; |
| + |
| + success = success = Should("node.gain.value", node.gain.value) |
| + .beEqualTo(1) && success; |
| + |
| + success = success = Should("node.channelCount", node.channelCount) |
| + .beEqualTo(2) && success; |
| + success = success = Should("node.channelCountMode", node.channelCountMode) |
| + .beEqualTo("max") && success; |
| + success = success = Should("node.channelInterpretation", node.channelInterpretation) |
| + .beEqualTo("speakers") && success; |
| + |
| + Should("new GainNode(context)", success) |
| + .summarize( |
| + "constructed node with correct attributes", |
| + "did not construct correct node correctly") |
| + |
| + taskDone(); |
| + }); |
| + |
| + audit.defineTask("test AudioNodeOptions", function (taskDone) { |
| + testAudioNodeOptions(context, "GainNode"); |
| + taskDone(); |
| + }); |
| + |
| + audit.defineTask("constructor with options", function (taskDone) { |
| + var node; |
| + var success = true; |
| + var options = { |
| + gain: -2, |
| + }; |
| + |
| + success = success = Should("node = new GainNode(context, <options>)", function () { |
| + node = new GainNode(context, options); |
| + }).notThrow(); |
| + success = success = Should("node instanceof GainNode", |
|
hongchan
2016/09/13 22:13:22
Ditto.
Raymond Toy
2016/09/14 18:02:23
Done.
|
| + node instanceof GainNode) |
| + .beEqualTo(true) && success; |
| + |
| + success = success = Should("node.gain.value", node.gain.value) |
| + .beEqualTo(options.gain) && success; |
| + |
| + success = success = Should("node.channelCount", node.channelCount) |
| + .beEqualTo(2) && success; |
| + success = success = Should("node.channelCountMode", node.channelCountMode) |
| + .beEqualTo("max") && success; |
| + success = success = Should("node.channelInterpretation", node.channelInterpretation) |
| + .beEqualTo("speakers") && success; |
| + |
| + Should("new GainNode() with options", success) |
| + .summarize( |
| + "constructed with correct attributes", |
| + "was not constructed correctly"); |
| + |
| + taskDone(); |
| + }); |
| + |
| + audit.runTasks(); |
| + </script> |
| + </body> |
| +</html> |
