Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html

Issue 2102133002: Add constructors for WebAudio nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt ('K') | « third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html » ('j') | third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html b/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
new file mode 100644
index 0000000000000000000000000000000000000000..fd4db2540a208b7cb0fa8957fd3ab9d602d5263a
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
@@ -0,0 +1,200 @@
+<!doctype html>
+<html>
+ <head>
+ <title>Test Constructor: AnalyserNode</title>
+ <script src="../../resources/testharness.js"></script>
+ <script src="../../resources/testharnessreport.js"></script>
+ <script src="../resources/audio-testing.js"></script>
+ <script src="audionodeoptions.js"></script>
+ </head>
+
+ <body>
+ <script>
+ var context;
+
+ var audit = Audit.createTaskRunner();
+
+ audit.defineTask("initialize", function (taskDone) {
+ Should("context = new OfflineAudioContext(...)", function () {
+ context = new OfflineAudioContext(1, 1, 48000);
+ }).notThrow();
+
+ taskDone();
+ });
+
+ audit.defineTask("invalid constructor", function (taskDone) {
+ var node;
+ var success = true;
+
+ success = Should("new AnalyserNode()", function () {
+ node = new AnalyserNode();
+ }).throw("TypeError");
+ success = Should("new AnalyserNode(1)", function () {
+ node = new AnalyserNode(1) && success;
+ }).throw("TypeError");
+ success = Should("new AnalyserNode(context, 42)", function () {
+ node = new AnalyserNode(context, 42) && success;
+ }).throw("TypeError");
+
+ Should("Invalid constructors", success)
+ .summarize(
+ "correctly threw errors",
+ "did not throw errors in all cases");
+
+ taskDone();
+ });
+
+ audit.defineTask("default constructor", function (taskDone) {
+ var node;
+ var success = true;
+
+ success = Should("node = new AnalyserNode(context)", function () {
+ node = new AnalyserNode(context);
+ }).notThrow();
+ success = Should("node instanceof AnalyserNode", node instanceof AnalyserNode)
+ .beEqualTo(true) && success;
+ success = Should("node.fftSize", node.fftSize).beEqualTo(2048) && success;
+ success = Should("node.frequencyBinCount",
+ node.frequencyBinCount).beEqualTo(1024) && success;
+ success = Should("node.minDecibels", node.minDecibels).beEqualTo(-100) && success;
+ success = Should("node.maxDecibels", node.maxDecibels).beEqualTo(-30) && success;
+ // All AudioParams are stored as single precision values. Compare
+ // against the single-precision float value.
+ success = Should("node.smoothingTimeConstant", node.smoothingTimeConstant)
+ .beEqualTo(Math.fround(0.8)) && success;
+
+ Should("new AnalyserNode(context)", success)
+ .summarize(
+ "constructed node with correct attributes",
+ "did not construct correct node correctly")
+
+ taskDone();
+ });
+
+ audit.defineTask("test AudioNodeOptions", function (taskDone) {
+ testAudioNodeOptions(context, "AnalyserNode");
+ taskDone();
+ });
+
+ audit.defineTask("constructor with options", function (taskDone) {
+ var options = {
+ fftSize: 32,
+ maxDecibels: 1,
+ minDecibels: -13,
+ // Choose a value that can be represented the same as a float and as a
+ // double.
+ smoothingTimeConstant: 0.125
+ };
+
+ var node;
+ var success = true;
+ success = Should("node = new AnalyserNode(context, ...)", function () {
+ node = new AnalyserNode(context, options);
+ }).notThrow();
+
+ success = Should("node instanceof AnalyserNode", node instanceof AnalyserNode)
+ .beEqualTo(true) && success;
+ success = Should("node.fftSize", node.fftSize)
+ .beEqualTo(options.fftSize) && success;
+ success = Should("node.maxDecibels", node.maxDecibels)
+ .beEqualTo(options.maxDecibels) && success;
+ success = Should("node.minDecibels", node.minDecibels)
+ .beEqualTo(options.minDecibels) && success;
+ success = Should("node.smoothingTimeConstant", node.smoothingTimeConstant)
+ .beEqualTo(options.smoothingTimeConstant) && success;
+
+ Should("new AnalyserNode() with options", success)
+ .summarize(
+ "constructed with correct attributes",
+ "was not constructed correctly");
+
+ taskDone();
+ });
+
+ audit.defineTask("construct invalid options", function (taskDone) {
+ var node;
+ var success = true;
+
+ success = Should("node = new AnalyserNode(..., { fftSize: 33 })", function () {
+ node = new AnalyserNode(context, {
+ fftSize: 33
+ });
+ }).throw("IndexSizeError") && success;
+ success = Should("node = new AnalyserNode(..., { maxDecibels: -500 })", function () {
+ node = new AnalyserNode(context, {
+ maxDecibels: -500
+ });
+ }).throw("IndexSizeError") && success;
+ success = Should("node = new AnalyserNode(..., { minDecibels: -10 })", function () {
+ node = new AnalyserNode(context, {
+ minDecibels: -10
+ });
+ }).throw("IndexSizeError") && success;
+ success = Should("node = new AnalyserNode(..., { smoothingTimeConstant: 2 })", function () {
+ node = new AnalyserNode(context, {
+ smoothingTimeConstant: 2
+ });
+ }).throw("IndexSizeError") && success;
+ success = Should("node = new AnalyserNode(..., { frequencyBinCount: 33 })", function () {
+ node = new AnalyserNode(context, {
+ frequencyBinCount: 33
+ });
+ }).notThrow() && success;
+ success = Should("node.frequencyBinCount", node.frequencyBinCount).beEqualTo(1024) &&
+ success;
+
+ Should("new AnalyserNode() with invalid option values", success)
+ .summarize(
+ "correctly handled",
+ "was not correctly handled");
+
+ taskDone();
+ });
+
+ audit.defineTask("setting min/max", function (taskDone) {
+ var node;
+ var success = true;
+
+ // Recall the default values of minDecibels and maxDecibels are -100,
+ // and -30, respectively. Setting both values in the constructor should
+ // not signal an error in any of the following cases.
+ success = Should("node = new AnalyserNode(..., {minDecibels: -10, maxDecibels: 20})",
hongchan 2016/09/13 22:13:22 var opts = { minDecibels: -10, maxDecibels: 20 };
Raymond Toy 2016/09/14 18:02:22 Done.
+ function () {
+ node = new AnalyserNode(context, {minDecibels: -10, maxDecibels: 20});
+ }).notThrow() && success;
+ success = Should("node = new AnalyserNode(..., {maxDecibels: 20, minDecibels: -10})",
+ function () {
+ node = new AnalyserNode(context, {maxDecibels: 20, minDecibels: -10});
+ }).notThrow() && success;
+
+ success = Should("node = new AnalyserNode(..., {minDecibels: -200, maxDecibels: -150})",
+ function () {
+ node = new AnalyserNode(context, {minDecibels: -200, maxDecibels: -150});
+ }).notThrow() && success;
+
+ success = Should("node = new AnalyserNode(..., {maxDecibels: -150, minDecibels: -200})",
+ function () {
+ node = new AnalyserNode(context, {maxDecibels: -150, minDecibels: -200});
+ }).notThrow() && success;
+
+ // But these should signal because minDecibel > maxDecibel
+ success = Should("node = new AnalyserNode(..., {maxDecibels: -150, minDecibels: -10})",
+ function () {
+ node = new AnalyserNode(context, {maxDecibels: -150, minDecibels: -10});
+ }).throw("IndexSizeError") && success;
+ success = Should("node = new AnalyserNode(..., {minDecibels: -10, maxDecibels: -150})",
+ function () {
+ node = new AnalyserNode(context, {minDecibels: -10, maxDecibels: -150});
+ }).throw("IndexSizeError") && success;
+
+ Should("new AnalyserNode with minDecibels/maxDecibels options values", success)
+ .summarize(
+ "correctly handled",
+ "incorrectly handled");
+
+ taskDone();
+ });
+ audit.runTasks();
+ </script>
+ </body>
+</html>
« third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt ('K') | « third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html » ('j') | third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698