Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl

Issue 2102133002: Add constructors for WebAudio nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/OscillatorOptions.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl
diff --git a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl
index ce401f5a45277fb7d5975c13f83b9a194a21996a..49a5e26aa4eadaad3d100f719139cc913a01f6d4 100644
--- a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl
+++ b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl
@@ -22,6 +22,7 @@
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+// See https://webaudio.github.io/web-audio-api/#the-oscillatornode-interface
enum OscillatorType {
"sine",
"square",
@@ -32,7 +33,9 @@ enum OscillatorType {
// OscillatorNode is an audio generator of periodic waveforms.
[
- ActiveScriptWrappable,
+ Constructor(BaseAudioContext context, optional OscillatorOptions options),
+ RaisesException=Constructor,
+ ActiveScriptWrappable,
]
interface OscillatorNode : AudioSourceNode {
« third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/OscillatorOptions.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698