third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.idl - Issue 2102133002: Add constructors for WebAudio nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.idl

Issue 2102133002: Add constructors for WebAudio nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceOptions.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.idl

diff --git a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.idl b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.idl

index 8f96e41ae30a90e92d85ff1df12b5b38bc06ea6e..ab4bbccb5906c2df50587ed2670741c7eeeba8ed 100644

--- a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.idl

+++ b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.idl

@@ -22,6 +22,12 @@

* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+// See https://webaudio.github.io/web-audio-api/#MediaElementAudioSourceNode

+ // TODO(rtoy): This should be AudioContext, not BaseAudioContext.

+ Constructor(BaseAudioContext context, MediaElementAudioSourceOptions options),

+ RaisesException=Constructor,

interface MediaElementAudioSourceNode : AudioSourceNode {

readonly attribute HTMLMediaElement mediaElement;

};