Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

Issue 2102133002: Add constructors for WebAudio nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
index 7b7765e9544039323b1b4cc5f394dbb2222f19df..123ee8b3a1f606e1e8db971469d843d23c7ce5e9 100644
--- a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
@@ -25,6 +25,7 @@
#include "modules/webaudio/BiquadFilterNode.h"
#include "modules/webaudio/AudioBasicProcessorHandler.h"
+#include "modules/webaudio/BiquadFilterOptions.h"
#include "platform/Histogram.h"
#include "wtf/PtrUtil.h"
@@ -66,6 +67,29 @@ BiquadFilterNode* BiquadFilterNode::create(BaseAudioContext& context, ExceptionS
return new BiquadFilterNode(context);
}
+BiquadFilterNode* BiquadFilterNode::create(BaseAudioContext* context, const BiquadFilterOptions& options, ExceptionState& exceptionState)
+{
+ BiquadFilterNode* node = create(*context, exceptionState);
+
+ if (!node)
+ return node;
hongchan 2016/09/12 18:56:32 return nullptr;
+
+ node->handleChannelOptions(options, exceptionState);
+
+ if (options.hasType())
+ node->setType(options.type());
+ if (options.hasQ())
+ node->q()->setValue(options.Q());
+ if (options.hasDetune())
+ node->detune()->setValue(options.detune());
+ if (options.hasFrequency())
+ node->frequency()->setValue(options.frequency());
+ if (options.hasGain())
+ node->gain()->setValue(options.gain());
+
+ return node;
+}
+
DEFINE_TRACE(BiquadFilterNode)
{
visitor->trace(m_frequency);

Powered by Google App Engine
This is Rietveld 408576698