third_party/WebKit/Source/modules/webaudio/AnalyserOptions.idl - Issue 2102133002: Add constructors for WebAudio nodes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/AnalyserOptions.idl

Issue 2102133002: Add constructors for WebAudio nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add use counters for all constructors Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4
	haraken 2016/09/09 00:57:10 Add a link to the spec. The same comment for other Add a link to the spec. The same comment for other IDL files in this CL. Raymond Toy 2016/09/09 17:32:53 Done, for the dictionaries. Did you want links fo Show quoted text On 2016/09/09 00:57:10, haraken wrote: > > Add a link to the spec. The same comment for other IDL files in this CL. Done, for the dictionaries. Did you want links for all other IDL files that were modified too? haraken 2016/09/10 01:31:10 Yes, we want to have the spec link in all IDL file Show quoted text On 2016/09/09 17:32:53, Raymond Toy wrote: > On 2016/09/09 00:57:10, haraken wrote: > > > > Add a link to the spec. The same comment for other IDL files in this CL. > > Done, for the dictionaries. > > Did you want links for all other IDL files that were modified too? Yes, we want to have the spec link in all IDL files.
	5 dictionary AnalyserOptions : AudioNodeOptions {

	6 unsigned long fftSize = 2048;

	7 float maxDecibels = -30;

	8 float minDecibels = -100;

	9 float smoothingTimeConstant = 0.8;

	10 };

OLD	NEW