Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 210213002: [android_webview] Update max scroll offset from page scale change. (Closed)

Created:
6 years, 9 months ago by mkosiba (inactive)
Modified:
6 years, 9 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[android_webview] Update max scroll offset from page scale change. The maximum scroll offset is derived from page scale, so it should be updated whenever that changes. BUG=351677 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M android_webview/browser/browser_view_renderer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mkosiba (inactive)
PTAL. I know there are no tests. This is for two reasons: 1) you're going ...
6 years, 9 months ago (2014-03-24 16:21:03 UTC) #1
boliu
lgtm
6 years, 9 months ago (2014-03-24 16:29:37 UTC) #2
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 9 months ago (2014-03-25 10:18:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/210213002/1
6 years, 9 months ago (2014-03-25 10:18:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/210213002/1
6 years, 9 months ago (2014-03-25 12:53:26 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 16:21:38 UTC) #6
Message was sent while issue was closed.
Change committed as 259227

Powered by Google App Engine
This is Rietveld 408576698